Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path pattern builder #809

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Path pattern builder #809

wants to merge 39 commits into from

Commits on Feb 21, 2023

  1. draft proposal for pathPatternBuilder methods endsWith, under, and of… 

    … class
    @noodlze
    noodlze committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    cb49cfa View commit details
    Browse the repository at this point in the history

  2. add tests, add contains and extension option in PathPatternBuilder, r… 

    …ename under to startWith
    @noodlze
    noodlze committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    dd52fb4 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. refactoring, add rules: option can only be added once to PathPatternB… 

    …uilder, given same precedence, option added after overrides previous
    @noodlze
    noodlze committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    1e5be70 View commit details
    Browse the repository at this point in the history

  2. add cop[right header to PathPatternBuilderTest

    @noodlze
    noodlze committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    8a04af4 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernOptions.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Feb 26, 2023
    Configuration menu
    Copy the full SHA
    c709286 View commit details
    Browse the repository at this point in the history

  2. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernOption.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Feb 26, 2023
    Configuration menu
    Copy the full SHA
    de9fe40 View commit details
    Browse the repository at this point in the history

  3. shorten options name in PathPatternOptions

    @noodlze
    noodlze committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    2ee5317 View commit details
    Browse the repository at this point in the history

  4. add new constructor in DefaultPathPattern that does not require path … 

    …validation
    @noodlze
    noodlze committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    316bb2a View commit details
    Browse the repository at this point in the history

  5. allow multiple contain options in PathPatternBuilder, move buildOrder… 

    … logic from PathPatternOption to PathPatternBuilder
    @noodlze
    noodlze committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    0376f6d View commit details
    Browse the repository at this point in the history

  6. remove unused import

    @noodlze
    noodlze committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    c799e63 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ern.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    f524a6d View commit details
    Browse the repository at this point in the history

  2. Update common/src/test/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernBuilderTest.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    5d610a0 View commit details
    Browse the repository at this point in the history

  3. Update common/src/test/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernBuilderTest.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    1fd3bcd View commit details
    Browse the repository at this point in the history

  4. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernBuilder.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    dc5fd40 View commit details
    Browse the repository at this point in the history

  5. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernOption.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    da40567 View commit details
    Browse the repository at this point in the history

  6. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernOption.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    a53edb2 View commit details
    Browse the repository at this point in the history

  7. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernBuilder.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    06662c6 View commit details
    Browse the repository at this point in the history

  8. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernBuilder.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    986df3a View commit details
    Browse the repository at this point in the history

  9. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernBuilder.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    b460bfe View commit details
    Browse the repository at this point in the history

  10. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernOptions.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    0cf67c9 View commit details
    Browse the repository at this point in the history

  11. fix missing imports, checkstyle violations

    @noodlze
    noodlze committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    9a2b815 View commit details
    Browse the repository at this point in the history

  12. fix missing imports, address code style: prefer ImmutableList.Builder

    @noodlze
    noodlze committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    67bb127 View commit details
    Browse the repository at this point in the history

  13. use StringBuilder to combine for efficiency

    @noodlze
    noodlze committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    dbb142c View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. add new constructor in DefaultPathPattern for a single string

    @noodlze
    noodlze committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    3f5ab60 View commit details
    Browse the repository at this point in the history

  2. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ern.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    33ccb30 View commit details
    Browse the repository at this point in the history

  3. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernOptions.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    96f14ce View commit details
    Browse the repository at this point in the history

  4. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernOptions.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    469020d View commit details
    Browse the repository at this point in the history

  5. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernOptions.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    1ff349c View commit details
    Browse the repository at this point in the history

  6. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernBuilder.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    fe03245 View commit details
    Browse the repository at this point in the history

  7. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ernOptions.java

Co-authored-by: Ikhun Um <[email protected]>
    @noodlze @ikhoon
    noodlze and ikhoon authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    6e67360 View commit details
    Browse the repository at this point in the history

  8. improvements to PathPatternBuilder

    @noodlze
    noodlze committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    dac0a50 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. rename extension-> hasExtension, add javadoc to PathPatternBuilder op… 

    …tions: endsWith, startsWith, contains and hasExtension
    @noodlze
    noodlze committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    fe145a0 View commit details
    Browse the repository at this point in the history

  2. rename PathPattern#extension-> hasExtension

    @noodlze
    noodlze committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    aff50dd View commit details
    Browse the repository at this point in the history

  3. fix file extension regex and add test for regex matcher

    @noodlze
    noodlze committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    43aaa0c View commit details
    Browse the repository at this point in the history

  4. improve PathPattern#of that accepts pathPattern(s)

    @noodlze
    noodlze committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    09a4e3a View commit details
    Browse the repository at this point in the history

  5. minor edits to javadoc of PathPatternBuilder options

    @noodlze
    noodlze committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    7c87563 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. Update common/src/main/java/com/linecorp/centraldogma/common/PathPatt… 

    …ern.java

Co-authored-by: Trustin Lee <[email protected]>
    @noodlze @trustin
    noodlze and trustin authored Mar 19, 2023
    Configuration menu
    Copy the full SHA
    49b5d3f View commit details
    Browse the repository at this point in the history

  2. improve DefaultPathPattern constructor accepting PathPattern(s)

    @noodlze
    noodlze committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    0d85d78 View commit details
    Browse the repository at this point in the history

  3. dissolve PathPatternOptions and PathPatternOption, merge with PathPat… 

    …ternBuilder
    @noodlze
    noodlze committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    53ebe9f View commit details
    Browse the repository at this point in the history