Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MirroringCredential to Credential #1031

Merged
merged 5 commits into from
Sep 27, 2024

Commits on Aug 29, 2024

  1. Rename MirroringCredential to Credential

    Motivation:
    We decided to repurpose the `MirrorCredential` to manage all repository credentials, not just those specific to mirroring. To reflect this role, we should remove `Mirror` prefix from the class name.
    
    Caveat: This commit must be deployed to central dogma replicas after applying the changed from line#1030.
    
    Modifications:
    - Renamed `MirroringCredential` to `Credential` and moved its package.
    - Removed `hostnamePatterns` property in `Credential`.
    
    Result:
    - The renamed `Credential` class can now be used for managing various types of repository credentials, beyond just mirroring.
    minwoox committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0f0a489 View commit details
    Browse the repository at this point in the history
  2. more

    minwoox committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    6756dc0 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Address comments from @ikhoon

    minwoox committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f4cf91d View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    4ad622d View commit details
    Browse the repository at this point in the history
  2. Fix flaky

    minwoox committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    16f78fd View commit details
    Browse the repository at this point in the history