Rename MirroringCredential to Credential
#1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We decided to repurpose the `MirrorCredential` to manage all repository credentials, not just those specific to mirroring. To reflect this role, we should remove `Mirror` prefix from the class name. Caveat: This commit must be deployed to central dogma replicas after applying the changed from line#1030. Modifications: - Renamed `MirroringCredential` to `Credential` and moved its package. - Removed `hostnamePatterns` property in `Credential`. Result: - The renamed `Credential` class can now be used for managing various types of repository credentials, beyond just mirroring.
ikhoon
reviewed
Aug 30, 2024
| import com.linecorp.centraldogma.server.internal.credential.PublicKeyCredential; | ||
|
|
||
| /** | ||
| * The authentication credentials which are required when accessing the Git repositories. |
There was a problem hiding this comment.
Should we update Javadoc to reflect on the current usage?
server/src/main/java/com/linecorp/centraldogma/server/credential/Credential.java
Show resolved
Hide resolved
jrhee17
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We decided to repurpose the
MirrorCredentialto manage all repository credentials, not just those specific to mirroring. To reflect this role, we should removeMirrorprefix from the class name.Caveat: This commit must be deployed to central dogma replicas after applying the changes from #1030.
Modifications:
MirroringCredentialtoCredentialand moved its package.hostnamePatternsproperty inCredential.Result:
Credentialclass can now be used for managing various types of repository credentials, beyond just mirroring.