Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate the commit history page with query params #1028

Merged
merged 3 commits into from
Aug 28, 2024

Commits on Aug 27, 2024

  1. Paginate the commmit history page with query params

    Motivation:
    
    It was able to paginate the commit history page but a page index or
    a page size is not exposed in query parameters. Because these values
    were managed only as internal states of Javascript, it was not possible
    to share specific history as a URL.
    
    Modifications:
    
    - Update `Bradcrumbs` to specify query parameters
    - Increase the width of `CompareButton`
    - Add an option to render a custom component when data is empty in
      `DynamicDataTable`
    - Add an option to hide a go-to button in `PaginationBar`.
    - Expose a browse button when if the path is a directory in
      `HistoryList`
    - Refactored `HistoryListPage` to use query parameters to specify
      revision ranges.
    - Use a form tag to submit the revision range with an enter key in
      `ChangesViewPage`
    - Link to a history page instead of a commit page in a `FileEditor`
      - Commits for a specific file must be retrieved sequentially from the
        `HEAD` revision, the Central Dogma server has a limit of 1000
        if `maxCommits` is not specified. This means that a commit for a
        specific file is not indexed and may not be found in recent 1000
        commits.
      - As we can't scan the entire history, it would be better to show the
        history and guide the user to find a commit rather than failing to
        find a commit for the file.
    
    Result:
    
    You can now share a specific range of commit history as a URL.
    ikhoon committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b3955a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Fix minor bugs and lint

    ikhoon committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    bee440c View commit details
    Browse the repository at this point in the history
  2. clean up

    ikhoon committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ff5275a View commit details
    Browse the repository at this point in the history