Paginate the commit history page with query params #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
It was able to paginate the commit history page but a page index or
a page size is not exposed in query parameters. Because these values
were managed only as internal states of Javascript, it was not possible
to share specific history as a URL.
Modifications:
- Update `Bradcrumbs` to specify query parameters
- Increase the width of `CompareButton`
- Add an option to render a custom component when data is empty in
`DynamicDataTable`
- Add an option to hide a go-to button in `PaginationBar`.
- Expose a browse button when if the path is a directory in
`HistoryList`
- Refactored `HistoryListPage` to use query parameters to specify
revision ranges.
- Use a form tag to submit the revision range with an enter key in
`ChangesViewPage`
- Link to a history page instead of a commit page in a `FileEditor`
- Commits for a specific file must be retrieved sequentially from the
`HEAD` revision, the Central Dogma server has a limit of 1000
if `maxCommits` is not specified. This means that a commit for a
specific file is not indexed and may not be found in recent 1000
commits.
- As we can't scan the entire history, it would be better to show the
history and guide the user to find a commit rather than failing to
find a commit for the file.
Result:
You can now share a specific range of commit history as a URL.
|
jrhee17
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It could paginate the commit history page but a page index or a page size is not exposed in query parameters. Because these values were managed only as internal states of Javascript, sharing specific history as a URL was impossible.
Modifications:
Breadcrumbsto specify query parametersCompareButtonDynamicDataTablePaginationBar.HistoryListHistoryListPageto use query parameters to specify revision ranges.ChangesViewPageFileEditorHEADrevision, the Central Dogma server has a limit of 1000 ifmaxCommitsis not specified. This means a commit for a specific file is not indexed and may not be found in the recent 1000 commits.Result:
You can now share a specific range of commit history as a URL.