Skip to content

Commit

Permalink
warn when the provided meterRegistry collides with clientFactory's
Browse files Browse the repository at this point in the history
  • Loading branch information
jrhee17 committed Apr 26, 2021
1 parent 8775eeb commit 268209c
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public CentralDogma build() throws UnknownHostException {

final MeterRegistry meterRegistry = meterRegistry().orElse(clientFactory().meterRegistry());
if (meterRegistry().isPresent() && meterRegistry().get() != clientFactory().meterRegistry()) {
logger.info("The specified meterRegistry differs from the meterRegistry from clientFactory.");
logger.warn("The specified meterRegistry differs from the meterRegistry from clientFactory.");
}

final CentralDogma dogma = new LegacyCentralDogma(executor, builder.build(AsyncIface.class),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public CentralDogma build() throws UnknownHostException {

final MeterRegistry meterRegistry = meterRegistry().orElse(clientFactory().meterRegistry());
if (meterRegistry().isPresent() && meterRegistry().get() != clientFactory().meterRegistry()) {
logger.info("The specified meterRegistry differs from the meterRegistry from clientFactory.");
logger.warn("The specified meterRegistry differs from the meterRegistry from clientFactory.");
}

final CentralDogma dogma = new ArmeriaCentralDogma(executor,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
import com.linecorp.centraldogma.internal.CsrfToken;

import io.micrometer.core.instrument.MeterRegistry;
import io.micrometer.core.instrument.Metrics;

/**
* Builds a {@link CentralDogma} client.
Expand Down

0 comments on commit 268209c

Please sign in to comment.