warn if the meterRegistry is different

line · Apr 26, 2021 · 8775eeb · 8775eeb
1 parent 693f651
commit 8775eeb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/.../main/java/com/linecorp/centraldogma/client/armeria/legacy/LegacyCentralDogmaBuilder.java b/.../main/java/com/linecorp/centraldogma/client/armeria/legacy/LegacyCentralDogmaBuilder.java
@@ -17,6 +17,9 @@
 
 import java.net.UnknownHostException;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.linecorp.armeria.client.ClientBuilder;
 import com.linecorp.armeria.client.ClientRequestContext;
 import com.linecorp.armeria.client.encoding.DecodingClient;
@@ -39,6 +42,8 @@
  */
 @Deprecated
 public class LegacyCentralDogmaBuilder extends AbstractArmeriaCentralDogmaBuilder<LegacyCentralDogmaBuilder> {
+    private static final Logger logger = LoggerFactory.getLogger(LegacyCentralDogmaBuilder.class);
+
     /**
      * Returns a newly-created {@link CentralDogma} instance.
      *
@@ -68,7 +73,11 @@ public CentralDogma build() throws UnknownHostException {
 
         final EventLoopGroup executor = clientFactory().eventLoopGroup();
         final int maxRetriesOnReplicationLag = maxNumRetriesOnReplicationLag();
+
         final MeterRegistry meterRegistry = meterRegistry().orElse(clientFactory().meterRegistry());
+        if (meterRegistry().isPresent() && meterRegistry().get() != clientFactory().meterRegistry()) {
+            logger.info("The specified meterRegistry differs from the meterRegistry from clientFactory.");
+        }
 
         final CentralDogma dogma = new LegacyCentralDogma(executor, builder.build(AsyncIface.class),
                                                           meterRegistry);

diff --git a/...ia/src/main/java/com/linecorp/centraldogma/client/armeria/ArmeriaCentralDogmaBuilder.java b/...ia/src/main/java/com/linecorp/centraldogma/client/armeria/ArmeriaCentralDogmaBuilder.java
@@ -17,6 +17,9 @@
 
 import java.net.UnknownHostException;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.linecorp.armeria.client.ClientBuilder;
 import com.linecorp.armeria.client.ClientRequestContext;
 import com.linecorp.armeria.client.WebClient;
@@ -34,6 +37,8 @@
  */
 public final class ArmeriaCentralDogmaBuilder
         extends AbstractArmeriaCentralDogmaBuilder<ArmeriaCentralDogmaBuilder> {
+    private static final Logger logger = LoggerFactory.getLogger(ArmeriaCentralDogmaBuilder.class);
+
     /**
      * Returns a newly-created {@link CentralDogma} instance.
      *
@@ -46,7 +51,12 @@ public CentralDogma build() throws UnknownHostException {
                 newClientBuilder(scheme, endpointGroup, cb -> cb.decorator(DecodingClient.newDecorator()), "/");
         final EventLoopGroup executor = clientFactory().eventLoopGroup();
         final int maxRetriesOnReplicationLag = maxNumRetriesOnReplicationLag();
+
         final MeterRegistry meterRegistry = meterRegistry().orElse(clientFactory().meterRegistry());
+        if (meterRegistry().isPresent() && meterRegistry().get() != clientFactory().meterRegistry()) {
+            logger.info("The specified meterRegistry differs from the meterRegistry from clientFactory.");
+        }
+
         final CentralDogma dogma = new ArmeriaCentralDogma(executor,
                                                            builder.build(WebClient.class),
                                                            accessToken(), meterRegistry);