TW-1817 added french and russian translation in camera screen #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaledNjim
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev,
hieutbui,
tddang-linagora and
Te-Z
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2012 |
nqhhdev
reviewed
Sep 6, 2024
nqhhdev
reviewed
Sep 6, 2024
Co-authored-by: Huy Quang Nguyen <[email protected]>
hoangdat
reviewed
Sep 13, 2024
hoangdat
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#1817
Root cause
The package used for taking photos (wechat_camera_picker) does not provide translation for russian and french language
Solution
Added text delegate for russian and french
Impact description
If this is not a bug, please explain how the changes affect the project
Test recommendations
Recommendations for how to test this, or anything else you are worried about?
Resolved
Attach screenshots or videos demonstrating the changes
1817.webm