Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opencv #79

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Remove opencv #79

merged 7 commits into from
Sep 27, 2024

Conversation

aentwist
Copy link
Contributor

@aentwist aentwist commented Sep 7, 2024

See commits

Closes #78 ,#74

Related to #62

pyproject.toml Show resolved Hide resolved
Python 3.8 will be end-of-life in about 1 month. Drop support for it
to support numpy 2.

See https://devguide.python.org/versions/
We are using numpy. Specify it as a direct dependency. Upgrade it from 1
to 2.
@aentwist aentwist marked this pull request as draft September 7, 2024 06:36
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (4d9faa4) to head (8dd09cc).
Report is 10 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   98.17%   98.18%           
=======================================
  Files           4        4           
  Lines         549      550    +1     
=======================================
+ Hits          539      540    +1     
  Misses         10       10           
Flag Coverage Δ
unittests 98.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aentwist
Copy link
Contributor Author

aentwist commented Sep 7, 2024

LFG son

The `[tool.poetry.dev-dependencies]` section has been deprecated since
Poetry 1.2. Move to the equivalent `[tool.poetry.group.dev.dependencies]`.

See https://python-poetry.org/blog/announcing-poetry-1.2.0/#dependency-groups
Fix warnings when running tests.
@aentwist aentwist marked this pull request as ready for review September 7, 2024 07:07
@aentwist
Copy link
Contributor Author

@leng-yue up to you

@leng-yue leng-yue merged commit ad57b15 into leng-yue:main Sep 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency opencv-python
3 participants