update to scrcpy v2.4 (debugging)

[k23223]

1、更新到scrcpy v2.4 目前最新版(2024-03-03发布)
2、home back click 已测试

[leng-yue]

@aentwist Do you have any chance to test this PR? I don't have any android device currently.

[aentwist]

I don't know if it is normal but Im actually using an Android emulator on my PC, ldplayer in my case 😅 That is how my project is. Although I do have an android I am not up to speed on using it. Anyways testing using an emulator is probably fine, but I don't really have an interest in this edit: I couldnt read it, this is very interesting but I dont want to commit the time right now to figure out how to do thorogh testing. so I won't promise anything right now.

[ActualMasterOogway]

I don't know if it is normal but Im actually using an Android emulator on my PC, ldplayer in my case 😅 That is how my project is. Although I do have an android I am not up to speed on using it. Anyways testing using an emulator is probably fine, but I don't really have an interest in this edit: I couldnt read it, this is very interesting but I dont want to commit the time right now to figure out how to do thorogh testing. so I won't promise anything right now.

Hey, Im open up for testing only problem is I cant build the av version of your repo. Could u sync your fork for it to work?
Thanks in advance

[m-danya]

Seems to work smoothly, thanks!

[leng-yue]

Cool

[aentwist]

This commit has the test suite failing, looks like only one test. The test probably just needs updated for the new version of scrcpy, but I don't know whether anyone is up to speed enough at the moment to fix it. Any ideas?

    def test_control_touch():
>       assert control.touch(100, 200, scrcpy.ACTION_DOWN) == (
            b"\x02"  # TYPE_INJECT_TOUCH_EVENT
            + b"\x00"  # ACTION_DOWN
            + b"\xff\xff\xff\xff\xff\xff\xff\xff"  # Virtual touch id
            + b"\x00\x00\x00\x64"  # X: 100
            + b"\x00\x00\x00\xc8"  # Y: 200
            + b"\x07\x80\x04\x38"  # Resolution: (1920, 1080)
            + b"\xff\xff"  # Pressure: 100%
            + b"\x00\x00\x00\x01"  # Primary button
        )
E       AssertionError: assert b'\x02\x00\x124Vx\x87eC!\x00\x00\x00d\x00\x00\x00\xc8\x07\x80\x048\xff\xff\x00\x00\x00\x01\x00\x00\x00\x01' == b'\x02\x00\xff\xff\xff\xff\xff\xff\xff\xff\x00\x00\x00d\x00\x00\x00\xc8\x07\x80\x048\xff\xff\x00\x00\x00\x01'
E         At index 2 diff: b'\x12' != b'\xff'
E         Full diff:
E           (
E         -  b'\x02\x00\xff\xff\xff\xff\xff\xff\xff\xff\x00\x00\x00d\x00\x00'
E         +  b'\x02\x00\x124Vx\x87eC!\x00\x00\x00d\x00\x00\x00\xc8\x07\x80\x048\xff\xff'
E         -  b'\x00\xc8\x07\x80\x048\xff\xff\x00\x00\x00\x01',
E         ?          ---- ----    ^^  ^^^^^^
E         +  b'\x00\x00\x00\x01\x00\x00\x00\x01',
E         ?               ^  ^^
E           )

tests/test_control.py:34: AssertionError

[aentwist]

I think I can handle this

Genymobile/scrcpy#673 (comment)

https://github.com/Genymobile/scrcpy/blob/af573090741e73c66c4a543dcd94fd771c51b7be/app/tests/test_control_msg_serialize.c#L77-L114

[aentwist]

Ok got it, the test did just need updated. Next time maybe try using it... spooky otherwise :)

#79