Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(lint-style): make sure Python style errors fail the linting step; fix --fix mode #15954

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - fix(lint-style): make sure Python style errors fail the linting step; fix --fix mode #15954

wants to merge 6 commits into from

Commits on Aug 19, 2024

  1. fix(lint-style): make sure Python style errors fail the build 

    While at it, tweak the formatting of error messages slightly:
avoid an extra newline after the Python output,
and pluralise errors more correctly.

Now, we ought to use allUnexpectedError.size for checking:
otherwise, we may print about how to fix 0 errors :-)
    @grunweg
    grunweg committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    24514a4 View commit details
    Browse the repository at this point in the history

  2. Fix indentation error.

    @grunweg
    grunweg committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ec00e4b View commit details
    Browse the repository at this point in the history

  3. Fix print-style-errors.sh.

    @grunweg
    grunweg committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5841546 View commit details
    Browse the repository at this point in the history

  4. Bad test changes.

    @grunweg
    grunweg committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0f720b5 View commit details
    Browse the repository at this point in the history

  5. Auto-fixing works! \o/

    @grunweg
    grunweg committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1f298b3 View commit details
    Browse the repository at this point in the history

  6. Undo test change

    @grunweg
    grunweg committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4ae9f71 View commit details
    Browse the repository at this point in the history