[Merged by Bors] - fix(lint-style): make sure Python style errors fail the linting step; fix --fix mode #15954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 4ae9f71f08Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
grunweg
changed the title
grunweg
added
the
easy
While at it, tweak the formatting of error messages slightly: avoid an extra newline after the Python output, and pluralise errors more correctly. Now, we ought to use allUnexpectedError.size for checking: otherwise, we may print about how to fix 0 errors :-)
grunweg
force-pushed
the
MR-lint-style-error-reporting
branch
from
bf17116
to
24514a4
Compare
|
Good catch - there was another hidden bug (the --fix option was not percolating all the way down to lint-style.py). |
grunweg
changed the title
|
Yep, I merged this branch into #15934 and reviewdog is picking up the errors now! Great work! bors r+ |
bryangingechen
added
the
CI
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
… fix --fix mode (#15954) We need to pass any --fix flag down to `lint-style.py`; this detail got lost along the rewrite. While at it, tweak the formatting of error messages slightly: avoid an extra newline after the Python output, and pluralise errors more correctly.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
… fix --fix mode (#15954) We need to pass any --fix flag down to `lint-style.py`; this detail got lost along the rewrite. While at it, tweak the formatting of error messages slightly: avoid an extra newline after the Python output, and pluralise errors more correctly.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
… fix --fix mode (#15954) We need to pass any --fix flag down to `lint-style.py`; this detail got lost along the rewrite. While at it, tweak the formatting of error messages slightly: avoid an extra newline after the Python output, and pluralise errors more correctly.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
… fix --fix mode (#15954) We need to pass any --fix flag down to `lint-style.py`; this detail got lost along the rewrite. While at it, tweak the formatting of error messages slightly: avoid an extra newline after the Python output, and pluralise errors more correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass any --fix flag down to
lint-style.py; this detail got lost along the rewrite.While at it, tweak the formatting of error messages slightly: avoid an extra newline after the Python output,
and pluralise errors more correctly.