-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RingTheory.MvPowerSeries.Topology): define the product topology on mv power series #14866
base: master
Are you sure you want to change the base?
Conversation
PR summary 57fce93dadImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Co-authored-by: Filippo A. E. Nuccio <[email protected]>
Co-authored-by: Filippo A. E. Nuccio <[email protected]>
Co-authored-by: Filippo A. E. Nuccio <[email protected]>
Co-authored-by: Filippo A. E. Nuccio <[email protected]>
Co-authored-by: Filippo A. E. Nuccio <[email protected]>
Co-authored-by: Filippo A. E. Nuccio <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Johan Commelin <[email protected]>
Co-authored-by: Johan Commelin <[email protected]>
Co-authored-by: Johan Commelin <[email protected]>
Co-authored-by: Johan Commelin <[email protected]>
Co-authored-by: Johan Commelin <[email protected]>
Co-authored-by: Johan Commelin <[email protected]>
theorem MvPowerSeries.apply_eq_coeff {σ R : Type _} [Semiring R] (f : MvPowerSeries σ R) | ||
(d : σ →₀ ℕ) : f d = MvPowerSeries.coeff R d f := | ||
rfl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this go elsewhere?
theorem instTopologicalSemiring [Semiring R] [TopologicalSemiring R] : | ||
TopologicalSemiring (MvPowerSeries σ R) where | ||
continuous_add := continuous_pi fun d => Continuous.comp continuous_add | ||
(Continuous.prod_mk (Continuous.fst' (continuous_coeff R d)) | ||
(Continuous.snd' (continuous_coeff R d))) | ||
continuous_mul := continuous_pi fun _ => continuous_finset_sum _ (fun i _ => Continuous.comp | ||
continuous_mul (Continuous.prod_mk (Continuous.fst' (continuous_coeff R i.fst)) | ||
(Continuous.snd' (continuous_coeff R i.snd)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be shortened using dot-notation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to have both files in the same PR. I get to write twice as few comments 😁
@@ -176,6 +176,14 @@ theorem prod_add (f g : ι → α) (s : Finset ι) : | |||
simp only [mem_filter, mem_sdiff, not_and, not_exists, and_congr_right_iff] | |||
tauto) | |||
|
|||
theorem prod_one_add {f : ι → α} (s : Finset ι) : | |||
(s.prod fun i => 1 + f i) = s.powerset.sum fun t => t.prod f := by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(s.prod fun i => 1 + f i) = s.powerset.sum fun t => t.prod f := by | |
∏ i ∈ s, (1 + f i) = ∑ t ∈ s.powerset, t.prod f := by |
theorem instT2Space [T2Space R] : T2Space (MvPowerSeries σ R) := Pi.t2Space | ||
|
||
variable (R) in | ||
/-- coeff are continuous -/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/-- coeff are continuous -/ | |
/-- `MvPowerSeries.coeff` is continuous. -/ |
continuous_add := continuous_pi fun d => Continuous.comp continuous_add | ||
(Continuous.prod_mk (Continuous.fst' (continuous_coeff R d)) | ||
(Continuous.snd' (continuous_coeff R d))) | ||
continuous_mul := continuous_pi fun _ => continuous_finset_sum _ (fun i _ => Continuous.comp | ||
continuous_mul (Continuous.prod_mk (Continuous.fst' (continuous_coeff R i.fst)) | ||
(Continuous.snd' (continuous_coeff R i.snd)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try using fun_prop
here?
|
||
variable (R) in | ||
/-- coeff are continuous -/ | ||
theorem continuous_coeff [Semiring R] (d : σ →₀ ℕ) : Continuous (MvPowerSeries.coeff R d) := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theorem continuous_coeff [Semiring R] (d : σ →₀ ℕ) : Continuous (MvPowerSeries.coeff R d) := | |
@[fun_prop] | |
theorem continuous_coeff [Semiring R] (d : σ →₀ ℕ) : Continuous (MvPowerSeries.coeff R d) := |
|
||
variable {σ R} | ||
|
||
theorem continuous_C [Ring R] [TopologicalRing R] : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theorem continuous_C [Ring R] [TopologicalRing R] : | |
@[fun_prop] | |
theorem continuous_C [Ring R] [TopologicalRing R] : |
Let
R
be withSemiring R
andTopologicalSpace R
In this file we define the topology on
MvPowerSeries σ R
that corresponds to the simple convergence on its coefficients,
aka the product topology.
It is the coarsest topology for which all coefficients maps are continuous.
When
R
hasUniformSpace R
, we define the corresponding uniform structure.When the type of coefficients has the discrete topology,
it corresponds to the topology defined by [bourbaki1981], chapter 4, §4, n°2
Coauthored with María Inés de Frutos Fernández @mariainesdff