-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:(Combinatorics/SimpleGraph): connected SimpleGraph
forms a MetricSpace
#14715
Closed
Closed
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0d28e97
`not_reachable_iff_Walk_isEmpty`
Rida-Hamadani 401005c
init
Rida-Hamadani 353eb9c
provide API for `dist`
Rida-Hamadani 034f3b8
Merge branch 'master' into rida/refactorDist
Rida-Hamadani 1996e74
fixes
Rida-Hamadani ff344f9
prove `iInf_eq_zero`
Rida-Hamadani 033d3d9
docs and implicit params
Rida-Hamadani aff9421
remove duplicate
Rida-Hamadani fa54c4a
use naming convention
Rida-Hamadani 0a60d79
Apply suggestions from review.
Rida-Hamadani 7024912
revert unwanted naming changes
Rida-Hamadani 7d8a20b
Apply changes from review.
Rida-Hamadani f59304b
Apply suggestions from review.
Rida-Hamadani 183bcdd
Update Mathlib/Combinatorics/SimpleGraph/Metric.lean
Rida-Hamadani b0d41a2
feat: connected graph forms a metric space
Rida-Hamadani a9f18ca
remove Verts
Rida-Hamadani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a good idea. I know I suggested it, but I don't think it should be included in mathlib. The problem is that now
Verts G
is another way to refer to the vertex type, which will create issues.We should build a bridge to Quiver if we really want this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I will convert this to a draft and work on it.