-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:(Combinatorics/SimpleGraph): connected SimpleGraph
forms a MetricSpace
#14715
Conversation
co-authored-by: Bhavik Mehta <[email protected]>
co-authored-by: Kyle Miller <[email protected]>
co-authered-by: Bhavik Mehta <[email protected]>
co-authored-by: Bhavik Mehta co-authored-by: Kyle Miller
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
PR summary a9f18ca4e7
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Combinatorics.SimpleGraph.Metric | 523 | 870 | +347 (+66.35%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.Combinatorics.SimpleGraph.Metric |
347 |
Declarations diff
+ Connected.exists_walk_length_eq_dist
+ Connected.exists_walk_length_eq_edist
+ Reachable.exists_walk_length_eq_dist
+ Reachable.exists_walk_length_eq_edist
+ Walk.edist_le
+ dist_eq_sInf
+ edist
+ edist_comm
+ edist_eq_one_iff_adj
+ edist_eq_sInf
+ edist_eq_top_of_not_reachable
+ edist_eq_zero_iff
+ edist_le
+ edist_ne_top_iff_reachable
+ edist_pos_of_ne
+ edist_self
+ edist_triangle
+ exists_walk_of_edist_eq_coe
+ exists_walk_of_edist_ne_top
+ iInf_eq_top_of_isEmpty
+ iInf_eq_zero
+ iInf_toNat
+ instance (h : Connected G) : MetricSpace V
+ reachable_of_edist_ne_top
+ reverse_bijective
+ reverse_injective
+ reverse_surjective
- Connected.exists_walk_of_dist
- Reachable.exists_walk_of_dist
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
This PR/issue depends on: |
|
||
section Topology | ||
|
||
def Verts {V : Type*} (_ : SimpleGraph V) := V |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a good idea. I know I suggested it, but I don't think it should be included in mathlib. The problem is that now Verts G
is another way to refer to the vertex type, which will create issues.
We should build a bridge to Quiver if we really want this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I will convert this to a draft and work on it.
edist
and rewritedist
#14582