-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: lint upon importing Lake
in mathlib
#13836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 4508146924Import changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
leanprover-community-mathlib4-bot
added
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
and removed
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
labels
Jun 14, 2024
This PR/issue depends on:
|
Thanks! bors delegate+ |
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Thanks for the review! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
Co-authored-by: Matthew Ballard <[email protected]>
grunweg
changed the title
feat: lint in importing Lake in mathlib, inspired by #13779
feat: lint upon importing Jun 14, 2024
Lake
in mathlib
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
feat: lint upon importing
[Merged by Bors] - feat: lint upon importing Jun 14, 2024
Lake
in mathlibLake
in mathlib
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
Co-authored-by: Matthew Ballard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #13779.
Lake
underMathlib
#13779