-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Fix mispelled names #9983
[pt] Fix mispelled names #9983
Conversation
I wouldn't add multitoken expressions to Some person names could also be added to global_spelling.txt (but not Russian names like Gagarin). |
3957192
to
8cac7bf
Compare
I'm doing several things here:
Be that as it may, we need to make sure we check what the speller can already handle before adding entries blindly to |
9043ee6
to
9206fa3
Compare
I've moved a bunch of stuff off the Those files are very close to being clean, though there are still a couple of hundred entries in |
Marnie Simpson | ||
María Gabriela | ||
Adrian Fernández |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a misspelling in Spanish. Adrián Fernández: https://en.wikipedia.org/wiki/Adri%C3%A1n_Fern%C3%A1ndez
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't added any new names, I thought these had all already been approved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That's true. Don't worry about them. We can fix them afterward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can fix the ones you mentioned here with the next rebase, it's no biggie.
José Blanc de Portugal | ||
José Mouzinho d'Albuquerque | ||
José Mouzinho de Albuquerque |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both de
+ d'
?
Miguel Burnier | ||
Mike Penner | ||
Mikhail Yuryevich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid Russian names in global_spelling.txt because different languages use different spellings.
Is this one? https://pt.wikipedia.org/wiki/Mikhail_L%C3%A9rmontov
9206fa3
to
3930fb3
Compare
What I found in the PT diff:
Iuri Gagarine (wrong) suggested for Iuri Gagarin (correct);
Ulysses Guimaraes (wrong) suggested for Ulysses Guimarães (correct);
Waldir Maranhao (wrong) suggested for Waldir Maranhão (correct);
Jorge Vercilo (wrong) suggested for Jorge Vercillo (correct).
Probably a different issue, but I have also added an extra S to the personality names I have found in the neighboring tags, i.e., replaced the 0 in NPMS000 with NPMSS00. It should be used to distinguish people from places and organizations, but our words are barely tagged as such.
More names added to multiwords.txt, spelling.txt, and spelling_global.txt based on the PT diff findings.
There are some wrong suggestions in the PT_MULTITOKEN rules that will need more attention. For example,
Pára-quedistas
is corrected topara-quedistas
, when it should beparaquedistas
(post-1990). For now, I am adding these tospelling.txt
, but a more in-depth fix for this will be needed.@p-goulart feel free to revert, edit, or comment this branch with your insights.