Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fr] Grammalecte rules disable & CONFUSION_CE_L_ON_SELON rule creation #9351

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[fr] Grammalecte rules disable & CONFUSION_CE_L_ON_SELON rule creation #9351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0c6185
[fr] Grammalecte rules disable & CONFUSION_CE_L_ON_SELON rule creation
GillouLT Sep 19, 2023
834b2a7
[fr] Grammalecte rules disable & CONFUSION_CE_L_ON_SELON rule creation
GillouLT Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions ...uagetool-language-modules/fr/src/main/java/org/languagetool/rules/fr/GrammalecteRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,8 +455,41 @@ public class GrammalecteRule extends Rule {
"g2__conf_de_vconj__b1_a1_1",
"g2__conf_déterminant_mas_sing_verbe__b1_a1_1",
"g2__conj_2s_sans_sujet_xxxas_xxxes__b4_a1_",
"gv1__ppas_avoir_été__b2_a3_1",
"g2__conj_je__b2_a1_1"
"g3__infi_de_verbe__b5_a1_1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I think (hope?) the format is good here

"typo_points_superflus",
"g2__conf_la_là__b2_a1_1",
"g2__conj_2s_sans_sujet_xxxas_xxxes__b4_a1_1",
"g2__conf_non_verbe_après_préverbes__b5_a2_1",
"g2__conj_je__b2_a1_1",
"gv1__conf_vc_int_imp_verbe__b1_a1_1",
"date_nombres",
"gv1__imp_confusion_2e_pers_pluriel__b5_a1_1",
"g2__conf_tu_non_verbe__b1_a3_1",
"g2__conf_si_vconj__b2_a1_1",
"g2__conf_on_non_verbe__b1_a3_1",
"g2__conf_on_non_verbe__b2_a3_1",
"g2__conj_on__b1_a1_1",
"g3__gn_start_prn_1m__b1_a1_1",
"gv2__conj_vinfi_suj__b1_a1_1",
"g2__conf_plus_plu__b5_a1_1",
"g3__gn_det_epi_plur_3m__b1_a2_1",
"g3__gn_det_epi_sing_3m__b1_a3_1",
"g2__conf_sur_vconj__b1_a1_1",
"typo_guillemets_ouvrants_inverses1",
"typo_guillemets_ouvrants_inverses2",
"typo_guillemets_ouvrants_inverses3",
"typo_guillemets_fermants_inverses",
"typo_commencement_guillemets",
"typo_guillemets_typographiques_simples_doubles_fermants",
"typo_guillemets_typographiques_simples_doubles_ouvrants",
"typo_guillemets_ouvrants_perdus",
"typo_guillemets_fermants_perdus",
"typo_guillemet_simple_fermant_non_ouvert",
"typo_guillemet_simple_ouvrant_non_fermé",
"typo_cohérence_guillemets_chevrons_fermants",
"typo_cohérence_guillemets_chevrons_ouvrants",
"typo_cohérence_guillemets_doubles_fermants",
"typo_cohérence_guillemets_doubles_ouvrants"
));

public GrammalecteRule(ResourceBundle messages, GlobalConfig globalConfig) {
Expand Down
12 changes: 12 additions & 0 deletions languagetool-language-modules/fr/src/main/resources/org/languagetool/rules/fr/grammar.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47407,6 +47407,18 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<message>Vouliez-vous dire <suggestion>maître mot</suggestion> ?</message>
<example correction="maître mot">C'est le <marker>mettre mot</marker> de cette méthode.</example>
</rule>
<rule id="CONFUSION_CE_L_ON_SELON" name="confusion ce l'on selon" default="temp_off">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: oh wow, good rule! I don't see any possible FP!

<pattern>
<marker>
<token regexp="yes">ce|se</token>
<token>l'</token>
<token>on</token>
</marker>
<token postag="R pers.*" postag_regexp="yes"/>
</pattern>
<message>Vouliez-vous dire <suggestion>selon</suggestion> ?</message>
<example correction="Selon"><marker>Ce l'on</marker> moi, ce n'est pas une bonne idée.</example>
</rule>
</category>
<category id="CAT_ELISION" name="Élision">
<rulegroup id="ELISION_Y" name="élision y">
Expand Down