[fr] Grammalecte rules disable & CONFUSION_CE_L_ON_SELON rule creation #9351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucieSteib
approved these changes
Sep 19, 2023
| @@ -47407,6 +47407,18 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA | |||
| <message>Vouliez-vous dire <suggestion>maître mot</suggestion> ?</message> | |||
| <example correction="maître mot">C'est le <marker>mettre mot</marker> de cette méthode.</example> | |||
| </rule> | |||
| <rule id="CONFUSION_CE_L_ON_SELON" name="confusion ce l'on selon" default="temp_off"> | |||
There was a problem hiding this comment.
praise: oh wow, good rule! I don't see any possible FP!
| @@ -455,8 +455,41 @@ public class GrammalecteRule extends Rule { | |||
| "g2__conf_de_vconj__b1_a1_1", | |||
| "g2__conf_déterminant_mas_sing_verbe__b1_a1_1", | |||
| "g2__conj_2s_sans_sujet_xxxas_xxxes__b4_a1_", | |||
| "gv1__ppas_avoir_été__b2_a3_1", | |||
| "g2__conj_je__b2_a1_1" | |||
| "g3__infi_de_verbe__b5_a1_1", | |||
There was a problem hiding this comment.
thanks! I think (hope?) the format is good here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address: https://github.com/languagetooler-gmbh/recurring-issues/issues/3