Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] anglicisms cleanup #9045

Merged
merged 1 commit into from
Jul 26, 2023
Merged

[fr] anglicisms cleanup #9045

merged 1 commit into from
Jul 26, 2023

Conversation

LucieSteib
Copy link
Collaborator

@LucieSteib LucieSteib commented Jul 26, 2023

In the context of: https://github.com/languagetooler-gmbh/task-force-french/issues/33.
→ Anglicisms replacement rules should be moved to Style. This is the PR for OS.

grammar_os

Impacted rules

Old name New name Other change
FAKE_NEWS ANGLICISME_FAKE_NEWS  
MEDIA    
PAS_DE_TRAIT_UNION ANGLICISME_SEX_TOY  
TRAIT_UNION ANGLICISME_MOBILE_HOME  
HEURES   Message changed
HEURES   Message changed
HEURES   Message changed
TITRE_M   Message changed

Comments

Rules not moved, since they apply to word use in French and are not anglicisms per se:

  • MEDIA wasn't moved, since the rule really concerns the word media in French.
  • HEURES subrules were not moved, and the error message was modified from <message>Cette écriture peut être considérée comme un anglicisme.</message> to <message>Cette notation correspond à l'usage dans les pays anglo-saxons.</message>
  • TITRE_M rule were not moved, and the error message was modified from <message>Ce titre anglais doit être traduit en français.</message> to <message>Mr correspond à "mister" en anglais. Monsieur s'abrège M.</message>

The moved rules got a new name, starting with ANGLICISME. That should maybe be generalized to new anglicisms rules (and maybe even extended to legacy rules(?).

@LucieSteib LucieSteib requested a review from GillouLT July 26, 2023 10:46
Copy link
Collaborator

@GillouLT GillouLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@LucieSteib LucieSteib merged commit 93553ed into master Jul 26, 2023
1 check passed
@LucieSteib LucieSteib deleted the anglicisms_cleanup branch July 26, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants