Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newly discovered Psalm issues #45

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Oct 11, 2024

Q A
QA yes

Description

Addresses all the RiskyTruthyFalsyComparison issues surfaced by newer versions of Psalm.

Bumps dev deps

@gsteel
Copy link
Member Author

gsteel commented Oct 11, 2024

@SuperDJ - Please review - Once this is merged, #44 can be rebased and released

src/Response.php Outdated Show resolved Hide resolved
Addresses all the `RiskyTruthyFalsyComparison` issues surfaced by newer versions of Psalm.

Bumps dev deps

- Closes laminas#43
- Closes laminas#41

Signed-off-by: George Steel <[email protected]>
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@gsteel gsteel self-assigned this Oct 16, 2024
@gsteel gsteel merged commit 5e78651 into laminas:2.20.x Oct 16, 2024
11 checks passed
@gsteel gsteel deleted the green-ci branch October 16, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants