Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PHP 8.4 #44

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Added PHP 8.4 #44

merged 4 commits into from
Oct 18, 2024

Conversation

SuperDJ
Copy link
Contributor

@SuperDJ SuperDJ commented Oct 9, 2024 •
edited
Loading

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

Requires

Changed

@gsteel gsteel mentioned this pull request Oct 11, 2024
Merged
@gsteel gsteel added this to the 2.20.0 milestone Oct 11, 2024
gsteel
gsteel requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SuperDJ
I've sent in #45 to get CI green prior to this change

.laminas-ci.json Show resolved Hide resolved
gsteel
gsteel requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperDJ

Please can you fetch the most recent 2.20.x branch locally, rebase your changes onto the tip of 2.20.x and resolve the conflicts in compoer.json - You'll also need to refresh the lock-file once your rebase is complete and commit that too.

.laminas-ci.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@gsteel gsteel self-assigned this Oct 18, 2024
gsteel
gsteel approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SuperDJ

@gsteel gsteel merged commit 302d9a6 into laminas:2.20.x Oct 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsteel gsteel gsteel approved these changes

Assignees

@gsteel gsteel

Labels
Enhancement
Projects
PHP 8.4
Status: Done
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperDJ @gsteel @froschdesign