Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MethodGenerator parameter sorting, when an explicit sorting is provided #90

Merged
merged 6 commits into from
Jul 9, 2021
Merged

Fix MethodGenerator parameter sorting, when an explicit sorting is provided #90

merged 6 commits into from
Jul 9, 2021

Commits on Jul 7, 2021

  1. Fix MethodGenerator Parameter Position 

    The MethodGenerator doesn't seem to take any notice of the ParameterGenerator position property. This causes issues when adding properties out of order, especially with optional and variadic parameters.

Signed-off-by: Will Jones <[email protected]>
    Will Jones committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    f71c746 View commit details
    Browse the repository at this point in the history

  2. Fix CS issues 

    Signed-off-by: Will Jones <[email protected]>
    Will Jones committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    031451b View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Fix psalm failures 

    Signed-off-by: Will Jones <[email protected]>
    Will Jones committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    5ee025c View commit details
    Browse the repository at this point in the history

  2. Fix CS check 

    Signed-off-by: Will Jones <[email protected]>
    Will Jones committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    c472aa1 View commit details
    Browse the repository at this point in the history

  3. Remove stateful checks from MethodGenerator 

    Signed-off-by: Will Jones <[email protected]>
    Will Jones authored and Will Jones committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    66a3464 View commit details
    Browse the repository at this point in the history

  4. Requested Changes - PR laminas#90 

    Update tests, new method visibility, update psalm-baseline

Signed-off-by: Will Jones <[email protected]>
    Will Jones committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    e4cbad8 View commit details
    Browse the repository at this point in the history