Fix MethodGenerator parameter sorting, when an explicit sorting is provided
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 7, 2021 23:49
The MethodGenerator doesn't seem to take any notice of the ParameterGenerator position property. This causes issues when adding properties out of order, especially with optional and variadic parameters. Signed-off-by: Will Jones <[email protected]>
Signed-off-by: Will Jones <[email protected]>
Signed-off-by: Will Jones <[email protected]>
Ocramius
requested changes
Jul 8, 2021
Signed-off-by: Will Jones <[email protected]>
Signed-off-by: Will Jones <[email protected]>
willjones9
force-pushed
the
bugfix-MethodGenerator-Parameter-Position
branch
from
e5905df
to
66a3464
Compare
Ocramius
requested changes
Jul 8, 2021
|
@willjones-stratagem I just noticed that this patch targets Should we change the target branch to |
Update tests, new method visibility, update psalm-baseline Signed-off-by: Will Jones <[email protected]>
|
@Ocramius retargeting it works for me |
Ocramius
changed the title
MethodGenerator parameter sorting, when an explicit sorting is provided
|
Thanks @willjones-stratagem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MethodGenerator doesn't seem to take any notice of the ParameterGenerator position property. This causes issues when adding properties out of order, especially with optional and variadic parameters.