-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github actions #1
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
aa093ec
Add C++11 in core/CMakeLists.txt since sample-vpVelocityTwistMatrix-3…
s-trinh 1fe7792
Add brew update && brew upgrade for MacOS builds. Use 3.0 as minimum …
s-trinh 273f50c
Update #defined guard accordingly to vpMbKltTracker class.
s-trinh 136c90c
Remove #if defined VISP_HAVE_PUGIXML guard since now ViSP is always b…
s-trinh c81c08e
Allow to pass visp_config prefix to make
fspindle d65d382
Update instructions to build the project
fspindle 02e9323
Try removing OpenCV to let ViSP install the needed OpenCV dependency?
s-trinh 2d27c8f
Print Homebrew packages dependencies. Add ubuntu-extra.yml for extra …
s-trinh 94090d5
Remove matrix.build_type to avoid launching too much builds.
s-trinh 9d8e194
Forgot to remove if condition.
s-trinh 61b5cbe
Merge remote-tracking branch 'upstream/master' into feature/add_githu…
fspindle c767cbe
Update github action for macos
fspindle 5131eed
Fix typo
fspindle ae9f4cb
Remove brew update that doesn't seem to work
fspindle 806fc23
Remove workflow using brew install visp that brings visp-3.5.0
fspindle e3f011c
Worflow uses last 2 ubuntu releases (20.04 and 22.04)
fspindle f4e5ddc
Help detecting VTK by setting Qt5_DIR
fspindle 6f60bbc
Fix libdc1394-dev package installation
fspindle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
name: MacOS-dep-brew | ||
|
||
# https://www.jeffgeerling.com/blog/2020/running-github-actions-workflow-on-schedule-and-other-events | ||
on: | ||
push: | ||
pull_request: | ||
schedule: | ||
- cron: '0 2 * * SUN' | ||
|
||
jobs: | ||
build-macos-dep-brew: | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [macos-10.15, macos-11.0] | ||
|
||
steps: | ||
# https://github.com/marketplace/actions/cancel-workflow-action | ||
- name: Cancel Previous Runs | ||
uses: styfle/[email protected] | ||
with: | ||
access_token: ${{ github.token }} | ||
|
||
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
|
||
- name: Print system information | ||
run: sysctl -a | grep machdep.cpu | ||
|
||
- name: Print OS information | ||
run: system_profiler SPSoftwareDataType | ||
|
||
- name: Install dependencies | ||
run: brew install libpng libjpeg libdc1394 lapack eigen opencv librealsense libxml2 pcl visp | ||
|
||
- name: Configure CMake and build visp_sample | ||
run: | | ||
mkdir build && cd build | ||
cmake .. -DCMAKE_BUILD_TYPE=Release | ||
make -j2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
name: MacOS-dep-sec | ||
|
||
# https://www.jeffgeerling.com/blog/2020/running-github-actions-workflow-on-schedule-and-other-events | ||
on: | ||
push: | ||
pull_request: | ||
schedule: | ||
- cron: '0 2 * * SUN' | ||
|
||
jobs: | ||
build-macos-dep-sec: | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [macos-10.15, macos-11.0] | ||
|
||
steps: | ||
# https://github.com/marketplace/actions/cancel-workflow-action | ||
- name: Cancel Previous Runs | ||
uses: styfle/[email protected] | ||
with: | ||
access_token: ${{ github.token }} | ||
|
||
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
|
||
- name: Print system information | ||
run: sysctl -a | grep machdep.cpu | ||
|
||
- name: Print OS information | ||
run: system_profiler SPSoftwareDataType | ||
|
||
- name: Install dependencies | ||
run: brew install libpng libjpeg libdc1394 lapack eigen opencv librealsense libxml2 pcl | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
||
|
||
# Openblas location is exported explicitly because openblas is keg-only, | ||
# which means it was not symlinked into /usr/local/. | ||
- name: Clone and configure ViSP | ||
run: | | ||
git clone --depth 1 https://github.com/lagadic/visp.git ${HOME}/visp | ||
cd ${HOME}/visp | ||
export LDFLAGS="-L/usr/local/opt/openblas/lib" | ||
export CPPFLAGS="-I/usr/local/opt/openblas/include" | ||
mkdir build && cd build | ||
cmake .. -DCMAKE_FIND_FRAMEWORK=LAST -DBUILD_DEMOS=OFF -DBUILD_EXAMPLES=OFF -DBUILD_TESTS=OFF -DBUILD_TUTORIALS=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$(pwd)/install | ||
cat ViSP-third-party.txt | ||
|
||
- name: Build and install ViSP | ||
run: | | ||
cd ${HOME}/visp/build | ||
make -j2 install | ||
echo "VISP_DIR=$(pwd)/install" >> $GITHUB_ENV | ||
echo $VISP_DIR | ||
|
||
- name: Configure CMake and build visp_sample | ||
run: | | ||
mkdir build && cd build | ||
cmake .. -DCMAKE_BUILD_TYPE=Release | ||
make -j2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
name: Ubuntu-dep-src | ||
|
||
# https://www.jeffgeerling.com/blog/2020/running-github-actions-workflow-on-schedule-and-other-events | ||
on: | ||
push: | ||
pull_request: | ||
schedule: | ||
- cron: '0 2 * * SUN' | ||
|
||
jobs: | ||
build-ubuntu-dep-src: | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu-16.04, ubuntu-18.04, ubuntu-20.04] | ||
|
||
steps: | ||
# https://github.com/marketplace/actions/cancel-workflow-action | ||
- name: Cancel Previous Runs | ||
uses: styfle/[email protected] | ||
with: | ||
access_token: ${{ github.token }} | ||
|
||
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
|
||
- name: Print system information | ||
run: lscpu | ||
|
||
- name: Print OS information | ||
run: lsb_release -a | ||
|
||
- name: Install dependencies | ||
run: | | ||
sudo apt-get update && sudo apt-get install -y libx11-dev libdc1394-22-dev libv4l-dev gfortran liblapack-dev libopenblas-dev libeigen3-dev libopencv-dev libxml2-dev libpcl-dev | ||
sudo apt-get update && sudo apt-get install -y libssl-dev libusb-1.0-0-dev pkg-config libgtk-3-dev libglfw3-dev libgl1-mesa-dev libglu1-mesa-dev | ||
|
||
- name: Build librealsense2 from source | ||
run: | | ||
pwd | ||
git clone --depth 1 https://github.com/IntelRealSense/librealsense.git ${HOME}/librealsense | ||
cd ${HOME}/librealsense | ||
mkdir build && cd build && mkdir install | ||
cmake .. -DBUILD_EXAMPLES=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$(pwd)/install | ||
make -j2 install | ||
echo "REALSENSE2_DIR=$(pwd)/install" >> $GITHUB_ENV | ||
echo $REALSENSE2_DIR | ||
|
||
- name: Build ViSP from source | ||
run: | | ||
git clone --depth 1 https://github.com/lagadic/visp.git ${HOME}/visp | ||
cd ${HOME}/visp | ||
mkdir build && cd build && mkdir install | ||
cmake .. -DBUILD_DEMOS=OFF -DBUILD_EXAMPLES=OFF -DBUILD_TESTS=OFF -DBUILD_TUTORIALS=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$(pwd)/install | ||
cat ViSP-third-party.txt | ||
make -j2 install | ||
echo "VISP_DIR=$(pwd)/install" >> $GITHUB_ENV | ||
echo $VISP_DIR | ||
|
||
- name: Configure CMake and build visp_sample | ||
run: | | ||
mkdir build && cd build | ||
cmake .. -DCMAKE_BUILD_TYPE=Release | ||
make -j2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
project(sample-core) | ||
|
||
cmake_minimum_required(VERSION 3.0) | ||
cmake_minimum_required(VERSION 2.6) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To avoid a warning with cmake 3.19 we should put |
||
# C++11 is needed for brace-enclosed initializer list in sample-vpVelocityTwistMatrix-3.cpp:9:37 | ||
set(CMAKE_CXX_STANDARD 11) | ||
set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||
|
||
file(GLOB src_cpp RELATIVE ${CMAKE_CURRENT_LIST_DIR} "*.cpp") | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before
brew install ...
, I propose to addbrew update; brew upgrade
to test always with the most recent releases