Add Github actions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….cpp uses brace-enclosed initializer list. Add some Github actions to automatically check for correct visp_sample build.
fspindle
reviewed
Feb 8, 2021
.github/workflows/macos-dep-brew.yml
Outdated
| run: system_profiler SPSoftwareDataType | ||
|
|
||
| - name: Install dependencies | ||
| run: brew install libpng libjpeg libdc1394 lapack eigen opencv librealsense libxml2 pcl visp |
There was a problem hiding this comment.
Before brew install ..., I propose to add brew update; brew upgrade to test always with the most recent releases
.github/workflows/macos-dep-src.yml
Outdated
| run: system_profiler SPSoftwareDataType | ||
|
|
||
| - name: Install dependencies | ||
| run: brew install libpng libjpeg libdc1394 lapack eigen opencv librealsense libxml2 pcl |
core/CMakeLists.txt
Outdated
| @@ -1,6 +1,10 @@ | |||
| project(sample-core) | |||
|
|
|||
| cmake_minimum_required(VERSION 3.0) | |||
| cmake_minimum_required(VERSION 2.6) | |||
|
|
|||
There was a problem hiding this comment.
To avoid a warning with cmake 3.19 we should put cmake_minimum_required(VERSION 3.0)
Add #include <visp3/core/vpXmlParser.h> to solve the following error: [ 54%] Building CXX object mbt/CMakeFiles/sample-vpMbKltTracker-1.dir/sample-vpMbKltTracker-1.cpp.o /home/runner/work/visp_sample/visp_sample/mbt/sample-vpMbKltTracker-1.cpp: In function ‘int main()’: /home/runner/work/visp_sample/visp_sample/mbt/sample-vpMbKltTracker-1.cpp:30:3: error: ‘vpXmlParser’ has not been declared vpXmlParser::cleanup(); ^ make[2]: *** [mbt/CMakeFiles/sample-vpMbKltTracker-1.dir/sample-vpMbKltTracker-1.cpp.o] Error 1 make[1]: *** [mbt/CMakeFiles/sample-vpMbKltTracker-1.dir/all] Error 2 mbt/CMakeFiles/sample-vpMbKltTracker-1.dir/build.make:81: recipe for target 'mbt/CMakeFiles/sample-vpMbKltTracker-1.dir/sample-vpMbKltTracker-1.cpp.o' failed make[1]: *** Waiting for unfinished jobs.... CMakeFiles/Makefile2:5882: recipe for target 'mbt/CMakeFiles/sample-vpMbKltTracker-1.dir/all' failed [ 54%] Built target sample-vpKltOpencv Makefile:113: recipe for target 'all' failed make: *** [all] Error 2 Add explicit OpenBLAS dependency.
|
Don't know why but there are these errors on MacOS with OpenCV and ViSP installed from brew: https://github.com/lagadic/visp_sample/runs/1858303134?check_suite_focus=true |
…uilt with pugixml support. Remove obsolete vpXmlParser::cleanup(); and VISP_HAVE_XML2 in mbt code. Update correct guard for KLT and OpenCV availabilities in hybrid mbt.
|
1. Concerning MacOS with ViSP installed using brew
The right path is I think that the ViSP brew package installed using I don't know if we have to wait until ViSP brew package becomes updated, or if we have to do something. 2. Concerning github actions As mentioned in |
|
I was thinking that maybe since I was explicitely installing OpenCV, the newest version was installed, which would be incompatible with ViSP. But it looks like the same issue occurs when letting brew install the OpenCV dependency. From the logs: and (macos-10.15): dependencies tree (OpenCV is a dependency of ViSP)
|
|
@s-trinh Sorry I forgot this PR ! |
This release has some issues in propagating 3rd parties deps like OpenCV, PCL...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required dependencies seems to be:
Some previous build errors on Github actions:
Otherwise there are build errors since the sample code are not guarded with
#defineGithub actions will be run for each commit/PR or every sunday.
Github actions results can be seen here: https://github.com/s-trinh/visp_sample/actions