Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated experimental.FunctionListenerFactoryKey with experimental.WithFunctionListenerFactory #108

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Replace deprecated experimental.FunctionListenerFactoryKey with experimental.WithFunctionListenerFactory #108

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c81df63
fix: deprecated error of `experimental.FunctionListenerFactoryKey`
chansuke Jun 9, 2024
cd3d46f
chore: remove unnecessary comment
chansuke Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/e2e/profiler/profiler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,10 @@ func main() {
p := wzprof.ProfilingFor(guestBin)
cpu := p.CPUProfiler()
mem := p.MemoryProfiler()
ctx := context.WithValue(context.Background(),
experimental.FunctionListenerFactoryKey{},

// Use `WithFunctionListenerFactory` instead of ``FunctionListenerFactoryKey`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may not need this comment because this is very minor change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gekko0114
I will remove this, thanks

ctx := experimental.WithFunctionListenerFactory(
context.Background(),
experimental.MultiFunctionListenerFactory(
wzprof.Sample(sampleRate, cpu),
wzprof.Sample(sampleRate, mem),
Expand Down
Loading