-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.9] Update Azure documentation links #3715
[release-1.9] Update Azure documentation links #3715
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.9 #3715 +/- ##
============================================
Coverage 52.90% 52.90%
============================================
Files 182 182
Lines 18250 18250
============================================
Hits 9655 9655
Misses 8055 8055
Partials 540 540
☔ View full report in Codecov by Sentry. |
/retest-required |
/retest AKS provisioning flake AFAICT. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 6e4f0d17a270fc9b2b38f55d7be10f9ad62c6a25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov shouldn't be failing based on the content of this PR, but even if it does, it's not intended to block merging PRs. I'm not sure where our configuration is wrong–I thought we had this sorted out. |
We might be missing the patch config for the release-1.9 branch which we have in the main branch. cluster-api-provider-azure/.github/codecov.yml Lines 8 to 12 in 7659a9f
|
@willie-yao Do you think adding the patch config to the release branch would solve the problem ? |
I created a #3734 to ublock. Might help? |
@nawazkh Yes it will. This should've been backported so that's my bad! |
8b13dff
to
9f2a0f6
Compare
Could someone (re-)review this? I rebased it after the codecov change was merged to release-1.9. |
/lgtm |
LGTM label has been added. Git tree hash: 325ed62a6a532b89c0cd005ae3de23e504afe3db
|
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Manual cherry-pick of #3702, which works around the link checker linter failing azure.microsoft.com URLs.
Which issue(s) this PR fixes:
N/A
TODOs:
Release note: