Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.9] Update Azure documentation links #3715

Merged

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Manual cherry-pick of #3702, which works around the link checker linter failing azure.microsoft.com URLs.

Which issue(s) this PR fixes:

N/A

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (518ec61) 52.90% compared to head (9f2a0f6) 52.90%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.9    #3715   +/-   ##
============================================
  Coverage        52.90%   52.90%           
============================================
  Files              182      182           
  Lines            18250    18250           
============================================
  Hits              9655     9655           
  Misses            8055     8055           
  Partials           540      540           
Impacted Files Coverage Δ
api/v1beta1/azurecluster_validation.go 75.10% <ø> (ø)
api/v1beta1/azuremachine_types.go 20.00% <ø> (ø)
api/v1beta1/types.go 60.71% <ø> (ø)
azure/defaults.go 9.52% <ø> (ø)
azure/services/managedclusters/spec.go 41.77% <ø> (ø)
azure/services/virtualmachineimages/client.go 50.00% <0.00%> (ø)
exp/api/v1beta1/azuremachinepool_types.go 20.00% <ø> (ø)
azure/services/loadbalancers/spec.go 92.55% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mboersma
Copy link
Contributor Author

/retest-required

@mboersma
Copy link
Contributor Author

/retest

AKS provisioning flake AFAICT.

@mboersma
Copy link
Contributor Author

/retest

@mboersma mboersma requested review from nojnhuh and removed request for devigned July 17, 2023 14:40
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6e4f0d17a270fc9b2b38f55d7be10f9ad62c6a25

Copy link
Contributor Author

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@mboersma
Copy link
Contributor Author

Codecov shouldn't be failing based on the content of this PR, but even if it does, it's not intended to block merging PRs. I'm not sure where our configuration is wrong–I thought we had this sorted out.

@nawazkh
Copy link
Member

nawazkh commented Jul 17, 2023

We might be missing the patch config for the release-1.9 branch which we have in the main branch.

patch:
default:
target: auto
threshold: 1%
informational: true

@nawazkh
Copy link
Member

nawazkh commented Jul 17, 2023

We might be missing the patch config for the release-1.9 branch which we have in the main branch.

patch:
default:
target: auto
threshold: 1%
informational: true

@willie-yao Do you think adding the patch config to the release branch would solve the problem ?

@nawazkh
Copy link
Member

nawazkh commented Jul 17, 2023

We might be missing the patch config for the release-1.9 branch which we have in the main branch.

patch:
default:
target: auto
threshold: 1%
informational: true

@willie-yao Do you think adding the patch config to the release branch would solve the problem ?

I created a #3734 to ublock. Might help?

@willie-yao
Copy link
Contributor

We might be missing the patch config for the release-1.9 branch which we have in the main branch.

patch:
default:
target: auto
threshold: 1%
informational: true

@willie-yao Do you think adding the patch config to the release branch would solve the problem ?

@nawazkh Yes it will. This should've been backported so that's my bad!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@mboersma
Copy link
Contributor Author

Could someone (re-)review this? I rebased it after the codecov change was merged to release-1.9.

@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 19, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 325ed62a6a532b89c0cd005ae3de23e504afe3db

@k8s-ci-robot k8s-ci-robot merged commit 91cebeb into kubernetes-sigs:release-1.9 Jul 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants