address reviews 3

Signed-off-by: Sandipan Panda <[email protected]>

manifests/base/webhook/manifests.yaml

@@ -104,23 +104,3 @@ webhooks:
     resources:
     - xgboostjobs
   sideEffects: None
-- admissionReviewVersions:
-  - v1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /validate-kubeflow-org-v1-jaxjob
-  failurePolicy: Fail
-  name: validator.jaxjob.training-operator.kubeflow.org
-  rules:
-  - apiGroups:
-    - kubeflow.org
-    apiVersions:
-    - v1
-    operations:
-    - CREATE
-    - UPDATE
-    resources:
-    - jaxjobs
-  sideEffects: None

pkg/controller.v1/jax/jaxjob_controller_test.go

@@ -188,13 +188,13 @@ var _ = Describe("JAXJob controller", func() {
 					Type:    kubeflowv1.JobCreated,
 					Status:  corev1.ConditionTrue,
 					Reason:  commonutil.NewReason(kubeflowv1.JAXJobKind, commonutil.JobCreatedReason),
-					Message: fmt.Sprintf("JAXJob %s is created.", ns.Name+"/"+name),
+					Message: fmt.Sprintf("JAXJob %s is created.", name),
 				},
 				{
 					Type:    kubeflowv1.JobRunning,
 					Status:  corev1.ConditionTrue,
 					Reason:  commonutil.NewReason(kubeflowv1.JAXJobKind, commonutil.JobRunningReason),
-					Message: fmt.Sprintf("JAXJob %s is running.", name),
+					Message: fmt.Sprintf("JAXJob %s/%s is running.", ns.Name, name),
 				},
 			}, testutil.IgnoreJobConditionsTimes))
 
@@ -300,7 +300,7 @@ var _ = Describe("JAXJob controller", func() {
 					Type:    kubeflowv1.JobRunning,
 					Status:  corev1.ConditionTrue,
 					Reason:  commonutil.NewReason(kubeflowv1.JAXJobKind, commonutil.JobRunningReason),
-					Message: fmt.Sprintf("JAXJob %s is running.", name),
+					Message: fmt.Sprintf("JAXJob %s/%s is running.", ns.Name, name),
 				},
 			}, testutil.IgnoreJobConditionsTimes))