address reviews 2

Signed-off-by: Sandipan Panda <[email protected]>
kubeflow · Sep 6, 2024 · 8d9beee · 8d9beee
1 parent 6409859
commit 8d9beee
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 1 deletion.
diff --git a/.github/workflows/publish-example-images.yaml b/.github/workflows/publish-example-images.yaml
@@ -69,3 +69,7 @@ jobs:
             platforms: linux/amd64,linux/arm64
             dockerfile: examples/pytorch/mnist/Dockerfile-mpi
             context: examples/pytorch/mnist
+          - component-name: jaxjob-simple
+            platforms: linux/amd64,linux/arm64
+            dockerfile: examples/jax/cpu-demo/Dockerfile
+            context: examples/jax/cpu-demo
diff --git a/manifests/base/crds/kustomization.yaml b/manifests/base/crds/kustomization.yaml
@@ -6,3 +6,4 @@ resources:
   - kubeflow.org_xgboostjobs.yaml
   - kubeflow.org_mpijobs.yaml
   - kubeflow.org_paddlejobs.yaml
+  - kubeflow.org_jaxjobs.yaml
diff --git a/manifests/base/webhook/manifests.yaml b/manifests/base/webhook/manifests.yaml
@@ -104,3 +104,23 @@ webhooks:
     resources:
     - xgboostjobs
   sideEffects: None
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-kubeflow-org-v1-jaxjob
+  failurePolicy: Fail
+  name: validator.jaxjob.training-operator.kubeflow.org
+  rules:
+  - apiGroups:
+    - kubeflow.org
+    apiVersions:
+    - v1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - jaxjobs
+  sideEffects: None
diff --git a/manifests/base/webhook/patch.yaml b/manifests/base/webhook/patch.yaml
@@ -10,6 +10,9 @@
 - op: replace
   path: /webhooks/3/clientConfig/service/name
   value: training-operator
+- op: replace
+  path: /webhooks/4/clientConfig/service/name
+  value: training-operator
 - op: replace
   path: /metadata/name
   value: validator.training-operator.kubeflow.org
diff --git a/pkg/webhooks/jax/jaxjob_webhook_test.go b/pkg/webhooks/jax/jaxjob_webhook_test.go
@@ -156,7 +156,7 @@ func TestValidateV1JAXJob(t *testing.T) {
 									Containers: []corev1.Container{
 										{
 											Name:  "",
-											Image: "",
+											Image: "gcr.io/kubeflow-ci/jaxjob-simple_test:1.0",
 										},
 									},
 								},