-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Kubernetes v1.23 and support Kubernetes v1.26 #2177
Conversation
395f236
to
df3f7bb
Compare
It seems that manusa/actions-setup-minikub doesn't support v1.26. https://github.com/kubeflow/katib/actions/runs/5614686888/job/15213331797?pr=2177 So, we need to switch a way to set up minikube to https://github.com/medyagh/setup-minikube. |
/hold |
cd20f43
to
d4a3788
Compare
/lgtm |
Signed-off-by: Yuki Iwai <[email protected]>
d4a3788
to
52a78c0
Compare
@andreyvelich I rebased this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tenzen-y!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andreyvelich Thanks for restarting the job. |
/hold cancel |
What this PR does / why we need it:
I upgraded the Kubernetes dependencies to v1.26. By this PR, we drop support for the Kubernetes v1.23.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part-of #2155
Checklist:
/assign @andreyvelich @johnugeorge