Drop Kubernetes v1.24 and support Kubernetes v1.27 #2182
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
requested review from
andreyvelich,
anencore94 and
gaocegege
| @@ -114,33 +114,19 @@ func add(mgr manager.Manager, r reconcile.Reconciler) error { | |||
| // addWatch adds a new Controller to mgr with r as the reconcile.Reconciler | |||
| func addWatch(mgr manager.Manager, c controller.Controller) error { | |||
| // Watch for changes to Experiment | |||
| err := c.Watch(&source.Kind{Type: &experimentsv1beta1.Experiment{}}, &handler.EnqueueRequestForObject{}) | |||
| err := c.Watch(source.Kind(mgr.GetCache(), &experimentsv1beta1.Experiment{}), &handler.EnqueueRequestForObject{}) | |||
There was a problem hiding this comment.
The source.Kind{} typed. was replaced with source.Kind() function:
| eventHandler := handler.EnqueueRequestForOwner(mgr.GetScheme(), mgr.GetRESTMapper(), &experimentsv1beta1.Experiment{}, handler.OnlyControllerOwner()) | ||
| if err = c.Watch(source.Kind(mgr.GetCache(), &trialsv1beta1.Trial{}), eventHandler); err != nil { |
There was a problem hiding this comment.
The handler.EnqueueRequestForOwner{} typed was replaced with handler.EnqueueRequestForOwner() function:
tenzen-y
changed the title
@andreyvelich Thanks for the quick response. |
tenzen-y
force-pushed
the
upgrade-k8s-v1.27
branch
5 times, most recently
from
ce91b7b
to
d933f58
Compare
tenzen-y
changed the title
tenzen-y
changed the title
tenzen-y
force-pushed
the
upgrade-k8s-v1.27
branch
from
d933f58
to
2bee423
Compare
| // ExperimentDefaulter implements admission.DecoderInjector. | ||
| // A decoder will be automatically injected. | ||
|
|
||
| // InjectDecoder injects the decoder. | ||
| func (e *ExperimentDefaulter) InjectDecoder(d *admission.Decoder) error { | ||
| e.decoder = d | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
The admission.DecoderInjector was removed:
|
|
||
| "github.com/kubeflow/katib/pkg/webhook/v1beta1/experiment" | ||
| "github.com/kubeflow/katib/pkg/webhook/v1beta1/pod" | ||
| ) | ||
|
|
||
| func AddToManager(mgr manager.Manager, port int) error { | ||
| // Create a webhook server. | ||
| hookServer := &webhook.Server{ |
There was a problem hiding this comment.
The webhook.Server was replaced with interface one:
tenzen-y
changed the title
tenzen-y
force-pushed
the
upgrade-k8s-v1.27
branch
from
2bee423
to
6654e33
Compare
|
@andreyvelich @johnugeorge This PR is ready for review. PTAL. |
Signed-off-by: Yuki Iwai <[email protected]>
tenzen-y
force-pushed
the
upgrade-k8s-v1.27
branch
from
6654e33
to
69915d0
Compare
|
/hold cancel |
There was a problem hiding this comment.
Thank you for updating K8s version @tenzen-y!
I left a few comments.
pkg/client/controller/applyconfiguration/common/v1beta1/algorithmsetting.go
Show resolved
Hide resolved
|
Thank you @tenzen-y! |
|
/lgtm |
|
Let's merge it 🎉 |
What this PR does / why we need it:
I upgraded the Kubernetes dependencies to v1.27. By this PR, we drop support for the Kubernetes v1.24.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2155
Blocked on #2177 and #2178
/hold
Checklist: