Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add compatibility with Oracle pre-12c #256

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Fix: Add compatibility with Oracle pre-12c #256

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
964d4be
Fix: Add compatibility with Oracle pre-12c
azratul Jul 3, 2024
693471f
Refactor: Move global variable to new location in line with plugin st…
Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 39 additions & 7 deletions autoload/db_ui/schemas.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,16 +116,37 @@ let s:oracle_args = join(
\ ],
\ ";\n"
\ ).';'
let s:oracle_foreign_key_query = "

function! s:get_oracle_queries()
let common_condition = ""
let legacy = 0

if exists('g:is_oracle_legacy')
let legacy = g:is_oracle_legacy
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this variable to plugin/db_ui.vim, prefix it withdb_ui and default it to 0, similar to other variables in there:

let g:db_ui_is_oracle_legacy = get(g:, 'db_ui_is_oracle_legacy', 0)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested change has been made

endif

if !legacy
let common_condition = "AND U.common = 'NO'"
endif

let foreign_key_query = "
\SELECT /*csv*/ DISTINCT RFRD.table_name, RFRD.column_name, RFRD.owner
\ FROM all_cons_columns RFRD
\ JOIN all_constraints CON ON RFRD.constraint_name = CON.r_constraint_name
\ JOIN all_cons_columns RFRING ON CON.constraint_name = RFRING.constraint_name
\ JOIN all_users U ON CON.owner = U.username
\ WHERE CON.constraint_type = 'R'
\ AND U.common = 'NO'
\ " . common_condition . "
\ AND RFRING.column_name = '{col_name}'"
let s:oracle_schemes_tables_query = "

let schemes_query = "
\SELECT /*csv*/ username
\ FROM all_users U
\ WHERE 1 = 1
\ " . common_condition . "
\ ORDER BY username"

let schemes_tables_query = "
\SELECT /*csv*/ T.owner, T.table_name
\ FROM (
\ SELECT owner, table_name
Expand All @@ -134,21 +155,32 @@ let s:oracle_schemes_tables_query = "
\ FROM all_views
\ ) T
\ JOIN all_users U ON T.owner = U.username
\ WHERE U.common = 'NO'
\ WHERE 1 = 1
\ " . common_condition . "
\ ORDER BY T.table_name"

return {
\ 'foreign_key_query': printf(s:oracle_args, foreign_key_query),
\ 'schemes_query': printf(s:oracle_args, schemes_query),
\ 'schemes_tables_query': printf(s:oracle_args, schemes_tables_query),
\ }
endfunction

let oracle_queries = s:get_oracle_queries()

let s:oracle = {
\ 'callable': 'filter',
\ 'cell_line_number': 1,
\ 'cell_line_pattern': '^-\+\( \+-\+\)*',
\ 'default_scheme': '',
\ 'foreign_key_query': printf(s:oracle_args, s:oracle_foreign_key_query),
\ 'foreign_key_query': oracle_queries.foreign_key_query,
\ 'has_virtual_results': v:true,
\ 'parse_results': {results, min_len -> s:results_parser(results[3:], '\s\s\+', min_len)},
\ 'parse_virtual_results': {results, min_len -> s:results_parser(results[3:], '\s\s\+', min_len)},
\ 'requires_stdin': v:true,
\ 'quote': v:true,
\ 'schemes_query': printf(s:oracle_args, "SELECT /*csv*/ username FROM all_users WHERE common = 'NO' ORDER BY username"),
\ 'schemes_tables_query': printf(s:oracle_args, s:oracle_schemes_tables_query),
\ 'schemes_query': oracle_queries.schemes_query,
\ 'schemes_tables_query': oracle_queries.schemes_tables_query,
\ 'select_foreign_key_query': printf(s:oracle_args, 'SELECT /*csv*/ * FROM "%s"."%s" WHERE "%s" = %s'),
\ 'filetype': 'plsql',
\ }
Expand Down