Fix: Add compatibility with Oracle pre-12c #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristijanhusak
requested changes
Jul 4, 2024
autoload/db_ui/schemas.vim
Outdated
| let legacy = 0 | ||
|
|
||
| if exists('g:is_oracle_legacy') | ||
| let legacy = g:is_oracle_legacy |
There was a problem hiding this comment.
Add this variable to plugin/db_ui.vim, prefix it withdb_ui and default it to 0, similar to other variables in there:
let g:db_ui_is_oracle_legacy = get(g:, 'db_ui_is_oracle_legacy', 0)There was a problem hiding this comment.
The requested change has been made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the issue where the current schema scraping query does not support Oracle 12c and previous versions. The update modifies the query to be compatible with these versions, ensuring that the plugin can properly connect and retrieve all the necessary database information from Oracle 12c and earlier.
Changes
Testing
Related Issues
Additional Notes
Please review and test the changes to ensure compatibility with other database versions and configurations. Feedback and suggestions are welcome.