Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of eth_get_transaction_count function #983

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+19 −1
Open

Implementation of eth_get_transaction_count function #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad1fff8
Implementation of eth_get_transaction_count function
Gerson2102 Sep 26, 2024
6f3b58f
Refactoring validate nonce in validation.cairo
Gerson2102 Sep 26, 2024
2a6a15c
Changing the deprecated function
Gerson2102 Sep 27, 2024
0b018b7
Validating nonce without new function
Gerson2102 Sep 28, 2024
5253044
Adding method to interface and test it
Gerson2102 Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion crates/contracts/src/kakarot_core/eth_rpc.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,11 @@ pub impl EthRPC<
}

fn eth_get_transaction_count(self: @TContractState, address: EthAddress) -> u64 {
panic!("unimplemented")
let kakarot_state = KakarotState::get_state();
Gerson2102 marked this conversation as resolved.
Show resolved Hide resolved
let starknet_address = kakarot_state.get_starknet_address(address);
let account = IAccountDispatcher { contract_address: starknet_address };
let nonce = account.get_nonce();
nonce
}

fn eth_chain_id(self: @TContractState) -> u64 {
Expand Down Expand Up @@ -218,8 +222,11 @@ fn is_view(self: @KakarotCore::ContractState) -> bool {
mod tests {
use crate::kakarot_core::KakarotCore;
use crate::kakarot_core::eth_rpc::IEthRPC;
use crate::kakarot_core::interface::IExtendedKakarotCoreDispatcherTrait;
use crate::test_utils::{setup_contracts_for_testing, deploy_eoa};
use snforge_std::{start_cheat_chain_id_global, stop_cheat_chain_id_global};
use utils::constants::POW_2_53;
use evm::test_utils::evm_address;

fn set_up() -> KakarotCore::ContractState {
// Define the kakarot state to access contract functions
Expand All @@ -232,6 +239,14 @@ mod tests {
stop_cheat_chain_id_global();
}

#[test]
fn test_eth_get_transaction_count() {
let (_, kakarot_core) = setup_contracts_for_testing();
let _ = deploy_eoa(kakarot_core, evm_address());
// Deployed eoa should return a zero nonce
assert_eq!(kakarot_core.eth_get_transaction_count(evm_address()), 0);
}


#[test]
fn test_eth_chain_id_returns_input_when_less_than_pow_2_53() {
Expand Down
3 changes: 3 additions & 0 deletions crates/contracts/src/kakarot_core/interface.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ pub trait IExtendedKakarotCore<TContractState> {
/// Executes an EVM transaction and possibly modifies the state
fn eth_send_transaction(ref self: TContractState, tx: Transaction) -> (bool, Span<u8>, u64);

// Returns the transaction count (nonce) of the specified address
fn eth_get_transaction_count(self: @TContractState, address: EthAddress) -> u64;

/// Upgrade the KakarotCore smart contract
/// Using replace_class_syscall
fn upgrade(ref self: TContractState, new_class_hash: ClassHash);
Expand Down