Implementation of eth_get_transaction_count function #983
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was checking in the codebase for more places where we can now use the |
enitrat
reviewed
Sep 27, 2024
Gerson2102
force-pushed
the
tx-count
branch
from
d209a13
to
2a6a15c
Compare
enitrat
reviewed
Sep 28, 2024
enitrat
reviewed
Sep 28, 2024
|
I added one test. But I was thinking about change the nonce and check it again. But I dont really know how to do it... Maybe using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include changes on the following file
crates/contracts/src/kakarot_core/eth_rpc.cairo. I'm doing the implementation of the eth_get_transaction_count function. The issue is not done yet.Pull Request type
Normal
Please check the type of change your PR introduces:
Resolves: #942
Does this introduce a breaking change?
This change is