-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/controlplane: unit test apiserver #5576
operator/pkg/controlplane: unit test apiserver #5576
Conversation
d108b6f
to
cfb4288
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5576 +/- ##
=======================================
Coverage 39.02% 39.02%
=======================================
Files 650 650
Lines 45207 45207
=======================================
+ Hits 17641 17643 +2
Misses 26207 26207
+ Partials 1359 1357 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In this commit, we introduce unit tests for both control plane apiserver and aggregated apiserver for the operator. Signed-off-by: Mohamed Awnallah <[email protected]>
cfb4288
to
255b0b8
Compare
cc @XiShanYongYe-Chang All tests cases passed now after rebasing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we introduce unit tests for both control plane apiserver and aggregated apiserver for the operator.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491
Does this PR introduce a user-facing change?: