Build docker image with serdes #251
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ARG BASE_UI_IMAGE=ghcr.io/kafbat/kafka-ui:main | ||
| FROM $BASE_UI_IMAGE | ||
|
|
||
| ARG SERDE_SMILE_JAR=https://github.com/kafbat/ui-serde-smile/releases/download/v1.0.1/serde-smile-v1.0.1-jar-with-dependencies.jar | ||
|
There was a problem hiding this comment. Could we add glue serde also? |
||
| ARG SERDE_SMILE_VERSION=1.0.1 | ||
| USER root | ||
| RUN mkdir /usr/lib/serdes; \ | ||
| chown -R kafkaui:kafkaui /usr/lib/serdes | ||
| USER kafkaui | ||
|
|
||
| RUN cd /usr/lib/serdes; \ | ||
| wget -O "kafka-ui-smile-serde-${SERDE_SMILE_VERSION}.jar" $SERDE_SMILE_JAR | ||
| ENV kafka.clusters.0.serde.0.name="Smile" | ||
| ENV kafka.clusters.0.serde.0.filePath="/usr/lib/serdes/kafka-ui-smile-serde-${SERDE_SMILE_VERSION}.jar" | ||
| ENV kafka.clusters.0.serde.0.className="io.kafbat.serde.smile.SmileSerde" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that if we run this workflow without running our main image, we're gonna build an outdated image. We need to either depend on the base image workflow or use some other approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is possible, but I think it is better approach
this enables to track versioning of serders separatly from the kafka-ui main.