Build docker image with serdes #251
Conversation
kapybro
bot
added
status/triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
api/Dockerfile-Serdes
Outdated
| ARG BASE_UI_IMAGE=ghcr.io/kafbat/kafka-ui:main | ||
| FROM $BASE_UI_IMAGE | ||
|
|
||
| ARG SERDE_SMILE_JAR=https://github.com/kafbat/ui-serde-smile/releases/download/v1.0.1/serde-smile-v1.0.1-jar-with-dependencies.jar |
There was a problem hiding this comment.
Could we add glue serde also?
| @@ -0,0 +1,38 @@ | |||
| ARG BASE_UI_IMAGE=ghcr.io/kafbat/kafka-ui:main | |||
There was a problem hiding this comment.
This means that if we run this workflow without running our main image, we're gonna build an outdated image. We need to either depend on the base image workflow or use some other approach.
There was a problem hiding this comment.
it is possible, but I think it is better approach
this enables to track versioning of serders separatly from the kafka-ui main.
| @@ -0,0 +1,33 @@ | |||
| #!/bin/bash | |||
| # Smile | |||
| smile_latest_release=$(curl -s "https://api.github.com/repos/kafbat/ui-serde-smile/releases/latest") | |||
There was a problem hiding this comment.
Can we collapse this script even more so we can have a list of repos (like kafbat/ui-serde-smile) so we could iterate over it and pull each jar?
| wget -O "kafka-ui-smile-serde-${SERDE_SMILE_VERSION}.jar" $SERDE_SMILE_JAR | ||
|
|
||
| ENV kafka.clusters.0.serde.0.name="Smile" | ||
| ENV kafka.clusters.0.serde.0.filePath="/usr/lib/serdes/kafka-ui-serde-smile-${SERDE_SMILE_VERSION}.jar" |
There was a problem hiding this comment.
@kafbat/backend need to discuss this, perhaps we could introduce a way to load serdes from one common path so we don't have to add these many properties and delegate the rest (like serde properties) to the user
|
Haarolean
added
the
hacktoberfest-accepted
What changes did you make? (Give an overview)
Resolves #156
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)