-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_perception] support sensor_msgs/PanoramaInfo with adding a publisher to DualFisheyeToPanorama node #2579
Merged
k-okada
merged 10 commits into
jsk-ros-pkg:master
from
sktometometo:PR/add-panorama-info
Jul 11, 2021
Merged
[jsk_perception] support sensor_msgs/PanoramaInfo with adding a publisher to DualFisheyeToPanorama node #2579
k-okada
merged 10 commits into
jsk-ros-pkg:master
from
sktometometo:PR/add-panorama-info
Jul 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please cleate PR to https://github.com/ros/common_msgs/pulls
--
◉ Kei Okada
2021年3月12日(金) 8:51 Koki Shinjo ***@***.***>:
… I defined PanoramaInfo message for meta information of panorama images.
The message have fields below.
- header (std_msgs/Header)
- projection_model (string)
- describing the projection model of a panorama image.
- Currently, only "equirectangular" is used. But use of other
projection models is possible. e.g. "mercator"
- theta_min, theta_max, phi_min, phi_max (float64)
- describing the region of shown image in spherical coordinate
system <https://en.wikipedia.org/wiki/Spherical_coordinate_system>
And I added a publisher of PanoramaInfo.msg to DualFisheyeToPanorama for
example usage.
------------------------------
You can view, comment on, or merge this pull request online at:
#2579
Commit Summary
- [jsk_recognition_msgs] add PanoramaInfo.msg
- [jsk_perception] add a Publisher of PanoramaInfo to
dual_fisheye_to_panorama node
File Changes
- *M* jsk_perception/include/jsk_perception/dual_fisheye_to_panorama.h
<https://github.com/jsk-ros-pkg/jsk_recognition/pull/2579/files#diff-a4fe09c7d4bec16bd3150eb592811d103cee6e7d166e8bd981e7d6e4099847e5>
(4)
- *M* jsk_perception/src/dual_fisheye_to_panorama.cpp
<https://github.com/jsk-ros-pkg/jsk_recognition/pull/2579/files#diff-752499635bd725c972cec6c0c91f1e16123c6a2e99bf7a3d07f85a15ecb32d2a>
(10)
- *M* jsk_recognition_msgs/CMakeLists.txt
<https://github.com/jsk-ros-pkg/jsk_recognition/pull/2579/files#diff-edd8861c8a2edf1020dd887a14dc2c90da6b09bd02ce6f9a69c93eea184fc8fb>
(1)
- *A* jsk_recognition_msgs/msg/PanoramaInfo.msg
<https://github.com/jsk-ros-pkg/jsk_recognition/pull/2579/files#diff-f8134095ed332a0934d3b8445813c373b0be4f6312bc307bd83652779423f86c>
(19)
Patch Links:
- https://github.com/jsk-ros-pkg/jsk_recognition/pull/2579.patch
- https://github.com/jsk-ros-pkg/jsk_recognition/pull/2579.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2579>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYNXD2FQT5UWZ6Y73OISLTDFJPNANCNFSM4ZBHSX4A>
.
|
This reverts commit 1c6e3e2.
PanoramaInfo.msg is defined in ros/common_msgs#171. Change panorama info publisher of DualFisheyeToPanorama to use sensor_msgs/Panoramainfo |
sktometometo
changed the title
[jsk_recognition_msgs][jsk_perception] add the PanoramaInfo message and add a publisher to DualFisheyeToPanorama node
[jsk_perception] support sensor_msgs/PanoramaInfo with adding a publisher to DualFisheyeToPanorama node
Mar 12, 2021
Example usage of PanoramaInfo will be in #2581 |
k-okada
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
failing with
|
add PanoramaInfo on jsk_recognition_msgs until ros/common_msgs#171 merged
…r_msgs/PanoramaInfo" This reverts commit 6fd5dae , until ros/common_msgs#171 has merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I defined PanoramaInfo message for meta information of panorama images.
The message have fields below.
And I added a publisher of PanoramaInfo.msg to DualFisheyeToPanorama for example usage.