Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Common Quadrotor] support the common quadrotor platform #546

Merged
merged 10 commits into from
Sep 15, 2023
Merged

[Common Quadrotor] support the common quadrotor platform #546

merged 10 commits into from
Sep 15, 2023

Conversation

tongtybj
Copy link
Collaborator

What is this

Refactor the whole system to support common quadrotor platforms.

@tongtybj
Copy link
Collaborator Author

@Takuzumi240

Please use this as the base for common quadrotors

@sugikazu75
Copy link
Contributor

@tongtybj
I think we should merge these commits to master for new quadrotor users. I resolved conflits and fixed a little in this branch.
Can you condsider merging? or are there any tasks remained?

@tongtybj
Copy link
Collaborator Author

@sugikazu75

Thank you for your reminder. I will refactor all commits before merging, since there are some unnecessary conflicts with master branch.

@tongtybj
Copy link
Collaborator Author

Mini Quadrotor:

Screenshot from 2023-09-12 17-04-10

@tongtybj
Copy link
Collaborator Author

@sugikazu75

I manually merged sugikazu75@7930401 and sugikazu75@7930401 .

@tongtybj
Copy link
Collaborator Author

@sugikazu75 Please also review this PR.

@sugikazu75
Copy link
Contributor

@tongtybj
config file in hydrus package is used here.
So I think mini_quadrotor package should depend on hydrus or place the same file in this package.

@tongtybj tongtybj changed the title [Common Quadrotor][WIP] support the common quadrotor platform [Common Quadrotor] support the common quadrotor platform Sep 13, 2023
@tongtybj
Copy link
Collaborator Author

@sugikazu75

Thank you for your advice. Please check e72351f and 3ed55e8

@sugikazu75
Copy link
Contributor

LGTM

@tongtybj tongtybj merged commit 30474c8 into jsk-ros-pkg:master Sep 15, 2023
6 checks passed
@tongtybj tongtybj deleted the develop/mini_quadrotor_ branch November 17, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugikazu75 sugikazu75 Awaiting requested review from sugikazu75

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tongtybj @sugikazu75