Improving linked busses support #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced id with sourceId in function UpdateDeviceState and function UpdateDeviceState so that RunAction works even for linked busses.
Removed comment text.
Added check for all sources in linked busses in function getDeviceStates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the support for linked busses by updating:
function getDeviceStates- added linked busses logicfunction UpdateDeviceState- changed id to sourceId and added linked busses logicfunction initializeSource- changed id to sourceIdThis PR solves #704.
As a consequence this PR improves RunAction when defining multiple devices for the same source.
As a consequence the code to check the status for linked busses is now duplicated. This can later be improved.