[Bug]: Linked Busses not working - Windows V3.0.10

[lainol]

What happened?

Linked Busses don't work.

No matter what you select, no bus appears on the device menu and the tally always turns on when one of the sources is in program, instead of both having to be in program for the tally to turn on.

Tested on 2 pcs

Version

3.0.10

Distribution

Desktop

OS

Windows

What browsers are you seeing the problem on?

No response

If applicable, What Listener Clients are You Using?

Web (Chrome), M5 Stick

TallyArbiter configuration

{
  "security": {
    "jwt_private_key": "GiGgRbBcNVJaFLAD+g6Mu2YC0A6eXpSMpTx/38mp71RUjMh0+mAkQwZJHFUzslFDKJJxmTU8sGyYNW3eti8P/SwEUj8KBwy5bGhenQfXFJzo28ld72tkxr2LV3Qz83czBLTVDI5PtS213ZqAb+TLXveFnbRsFwQW8K9Em9n3dmW/JSUYPBQdR8rMXgTkhwReTZYvz9AH+MfOFBu5LFOWVsKmxsBfQ/Htd4nJKa8TrPUk3pWbTHCqtpOOrF5/0XWUb+jWg9KARh44ua5aTB6AYEy4RcpDFtiRvU96UY/chaff4dBPjJIocpKChdlpWS6HruiKveentp5TdUlJuCEQLQ=="
  },
  "users": [
    {
      "username": "producer",
      "password": "$2a$10$A9M7LNK/pCN01S.JENqnnOKSIG43GvMLT/7kQBphVoirKmw5PjOvW",
      "roles": "producer"
    },
    {
      "username": "admin",
      "password": "$2a$10$/l2NsLlQGNw0PLs75WW2YuK9cGlg8Bh0lhUwLHkWyehQXimI2P892",
      "roles": "admin"
    }
  ],
  "cloud_destinations": [],
  "cloud_keys": [],
  "device_actions": [],
  "device_sources": [
    {
      "deviceId": "bf5f1df1",
      "sourceIdx": "1",
      "sourceId": "da2a71da",
      "id": "fc04abb9",
      "rename": false,
      "address": "2"
    },
    {
      "deviceId": "bf5f1df1",
      "sourceIdx": "0",
      "address": "3",
      "sourceId": "76fc9cf5",
      "id": "ab0b9e8f",
      "rename": false
    }
  ],
  "devices": [
    {
      "name": "Web",
      "description": "",
      "linkedBusses": [
        "334e4eda"
      ],
      "enabled": true,
      "id": "bf5f1df1"
    }
  ],
  "sources": [
    {
      "data": {
        "ip": "192.168.1.230",
        "me_onair": [
          "1"
        ],
        "cut_bus_mode": "off"
      },
      "name": "atem",
      "sourceTypeId": "44b8bc4f",
      "reconnect": false,
      "enabled": true,
      "id": "76fc9cf5",
      "max_reconnects": 5,
      "connected": true
    },
    {
      "data": {
        "ip": "192.168.1.216"
      },
      "name": "vmix",
      "sourceTypeId": "58b6af42",
      "reconnect": true,
      "enabled": true,
      "id": "da2a71da",
      "max_reconnects": 5,
      "connected": true
    }
  ],
  "tsl_clients": [],
  "tsl_clients_1secupdate": false,
  "bus_options": [
    {
      "id": "e393251c",
      "label": "Preview",
      "type": "preview",
      "color": "#3fe481",
      "priority": 50
    },
    {
      "id": "334e4eda",
      "label": "Program",
      "type": "program",
      "color": "#e43f5a",
      "priority": 200
    },
    {
      "id": "12c8d699",
      "label": "Aux 1",
      "type": "aux",
      "color": "#0000FF",
      "priority": 100
    },
    {
      "id": "12c8d689",
      "label": "Aux 2",
      "type": "aux",
      "color": "#0000FF",
      "priority": 100
    }
  ],
  "externalAddress": "http://0.0.0.0:4455/#/tally",
  "remoteErrorReporting": false,
  "uuid": "7b93b8c7"
}

Relevant log output

No response

Error stacktrace (if applicable)

No response

[github-actions]

Hello there lainol 👋

Welcome to TallyArbiter!

Thank you for opening your first issue for the Tally Arbiter project. Tally Arbiter fosters an open and welcoming environment for all our contributors. Please adhere to our Code Of Conduct.

If you have more to contribute to this issue, please comment down below! We will try to get back to you as soon as we can.

[lainol]

Tested with docker... same result (or I'm dumb...).

[Jocke4f]

I did a quick test in Windows with v3.0.10 (actually latest form 2024-07-26) and linked busses doesn't work. I suspect that it is due to that the id and sourceId are mixed up in function UpdateDeviceState and function UpdateDeviceState . This also messes up RunAction when adding more then one device per camera. I have a fix for this part in https://github.com/Jocke4f/TallyArbiter/tree/fix_704_linked_busses.

I don't understand how the linked busses shall work, i.e., where the logic for handling the linked busses tally data shall be handled. @josephdadams can you give a hint where the logic for device tally status for linked busses should reside.

[Jocke4f]

My current best guess is that support for linked busses is missing in function getDeviceStates in index.ts. It is currently only a guess.

[Jocke4f]

The problem with linked busses was solved with #710.