Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add style target to makefile #324

Merged
merged 6 commits into from
Aug 14, 2024
Merged

add style target to makefile #324

merged 6 commits into from
Aug 14, 2024

Conversation

johko
Copy link
Owner

@johko johko commented Jul 23, 2024

Added the style target to the makefile, so you actually can run make style to fix formatting.
(command shamelessly copied from the audio course https://github.com/huggingface/audio-transformers-course/blob/main/Makefile )

@johko johko changed the base branch from main to stage July 23, 2024 20:54
Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed it. Please check it out 🤗

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

@mmhamdy mmhamdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @jungnerd has already noted most of the comments. Thanks @johko

johko and others added 2 commits July 25, 2024 22:56
Co-authored-by: Woojun Jung <[email protected]>
Co-authored-by: Woojun Jung <[email protected]>
@johko
Copy link
Owner Author

johko commented Jul 25, 2024

Thanks for the suggestions @jungnerd, both make sense to me 🤗

Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johko johko merged commit 89cde77 into stage Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants