Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added video processing section (Unit 7 - introduction ) #314

Merged
merged 7 commits into from
Aug 14, 2024

Conversation

jungnerd
Copy link
Contributor

Added introduction of video processing and updated credits

Copy link
Collaborator

@ATaylorAerospace ATaylorAerospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this intro. Just a couple of small nits have been noted

@jungnerd
Copy link
Contributor Author

Thanks for adding this intro. Just a couple of small nits have been noted

Thanks for the review 😍

@jungnerd
Copy link
Contributor Author

jungnerd commented Jul 4, 2024

@merveenoyan Would you mind reviewing this for merge?

@cjfghk5697
Copy link
Contributor

cjfghk5697 commented Jul 13, 2024

I'm not sure, but it seems like you should add this topic to the "toctree.yml".

Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I added some small proposals, actually all capitalization stuff, for consistency within the course.

But great work 👍

@jungnerd
Copy link
Contributor Author

Thanks for contributing! I added some small proposals, actually all capitalization stuff, for consistency within the course.

But great work 👍

Thanks for the review! I reflected your review and committed it!

Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick editing :)

@johko
Copy link
Owner

johko commented Jul 20, 2024

Looks like the quality check fails @jungnerd. Can you run make style from the root of your forked repository and commit the changed code? That should fix it

@jungnerd
Copy link
Contributor Author

jungnerd commented Jul 21, 2024

Looks like the quality check fails @jungnerd. Can you run make style from the root of your forked repository and commit the changed code? That should fix it

@johko
It looks like the Makefile does not contain a target for style, so make style fails. Can I add a style target to the Makefile to address this issue?

@johko
Copy link
Owner

johko commented Jul 23, 2024

Looks like the quality check fails @jungnerd. Can you run make style from the root of your forked repository and commit the changed code? That should fix it

@johko It looks like the Makefile does not contain a target for style, so make style fails. Can I add a style target to the Makefile to address this issue?

Ah yes, you're right. Strange, I thought it would be in there. I'll try to figure out what exactly make style should do and will either add it to he makefile myself and create a PR or tell you which command to run to fix the formatting @jungnerd

@johko
Copy link
Owner

johko commented Jul 23, 2024

I just created a PR which adds the command to the makefile: #324
It also fixes the file which was not correctly formatted (turns out it slipped in through an other PR and is not your fault).

As soon as my PR is merged, you can merge the changes into your branch and it should be good.

@jungnerd
Copy link
Contributor Author

I just created a PR which adds the command to the makefile: #324 It also fixes the file which was not correctly formatted (turns out it slipped in through an other PR and is not your fault).

As soon as my PR is merged, you can merge the changes into your branch and it should be good.

Great, thanks for checking 👍
I'll be waiting for your PR to be merged.

@johko
Copy link
Owner

johko commented Aug 14, 2024

@jungnerd I just merged the other PR (finally), so if you pull the upstream/main branch, the quality check should also work ;)

@johko
Copy link
Owner

johko commented Aug 14, 2024

nevermind, I could update it from here and will merge now 🙂

@johko johko merged commit eb3d94d into johko:main Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants