-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added video processing section (Unit 7 - introduction ) #314
Conversation
added video processing part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this intro. Just a couple of small nits have been noted
Co-authored-by: A Taylor <[email protected]>
Thanks for the review 😍 |
@merveenoyan Would you mind reviewing this for merge? |
I'm not sure, but it seems like you should add this topic to the "toctree.yml". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! I added some small proposals, actually all capitalization stuff, for consistency within the course.
But great work 👍
Co-authored-by: Johannes Kolbe <[email protected]>
Thanks for the review! I reflected your review and committed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick editing :)
Looks like the quality check fails @jungnerd. Can you run |
@johko |
Ah yes, you're right. Strange, I thought it would be in there. I'll try to figure out what exactly make style should do and will either add it to he makefile myself and create a PR or tell you which command to run to fix the formatting @jungnerd |
I just created a PR which adds the command to the makefile: #324 As soon as my PR is merged, you can merge the changes into your branch and it should be good. |
Great, thanks for checking 👍 |
@jungnerd I just merged the other PR (finally), so if you pull the upstream/main branch, the quality check should also work ;) |
nevermind, I could update it from here and will merge now 🙂 |
Added introduction of video processing and updated credits