Improving Chromecast Integration #1298
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 14, 2024 09:36
wait for 15 seconds before actually shutting down. this is because chromecast playback somethimes seems to play a track and when that one stops, plays another. That means, that stop is called in the mean time which causes the notification to disappear and the wake lock to be released which can cause errors an restarting the background service. to prevent this we wait 15 seconds before actually stopping the service, giving chromecast/jellyfin client time to start another track.
added 2 commits
February 15, 2024 15:07
|
Also fix the bug where swiping on the timeline does not work when casting to TV using Google Cast. Playback stops when you want to go to another time. This issue happens when sending from Jellyfin Web. |
|
Thanks for looking into this! So far, the changes look pretty good. Please tell me when you have specific questions about fixing the remaining TODOs. |
|
What's the state of this? Would you prefer to continue working on it first, or do you think we can already merge the existing changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is targeting Chrome Cast support in the Jellyfin Android app. Chromecast seems to have multiple issues in my environment and I am aiming to make it a smoother experience.
I am by far NOT an expert in Android development but I was involved in Android development, so I am not absolutely incompetent to make improvements. However my PRs should be taken with a grain of salt and I will probably need a fair amount of help.
Changed RemotePlayerService wake lock and foreground binding to ensure it does not get killed by OS
TODOs:
Issues