Fix background playback stopping on Android 14 #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service was not being properly started as a foreground service for media playback, causing playback stoppage after every track (or sooner for some folks), on android 14. Different vendors may be more aggressive with killing of non-foreground service etc, so people may have gotten different results.
Maxr1998
reviewed
Jun 25, 2024
app/src/main/java/org/jellyfin/mobile/webapp/RemotePlayerService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/mobile/webapp/RemotePlayerService.kt
Outdated
Show resolved
Hide resolved
Maxr1998
approved these changes
Jun 25, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemotePlayerServiceservice was not being properly started as a foreground service for media playback, causing playback stoppage after every track (or sooner for some folks), on android 14.Different vendors may be more or less aggressive with killing of non-foreground service etc, so people may have gotten different results from the same root issue.
Changes
RemotePlayerServiceto include theforegroundServiceType="mediaPlayback"attribute (see "Foreground service types are required")startForegroundinstead ofnotificationManager.notifyContextCompat.startForegroundServiceto send intents to the serviceSome of these changes can also be found in @dumpfheimer's PR Improving Chromecast Integration #1298
Issues
(For a bit of my background: my day job is working on a music streaming android app and we've previously hit similar issues)