django-redshift-backend depends directly on psycopg2. #149 #150
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimizukawa
force-pushed
the
149-depends-to-psycopg2
branch
from
10c8c3d
to
d7be65e
Compare
shimizukawa
force-pushed
the
149-depends-to-psycopg2
branch
from
d7be65e
to
02e1ab8
Compare
shimizukawa
force-pushed
the
149-depends-to-psycopg2
branch
from
02e1ab8
to
e04bce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #149.
Previously, django-redshift-backend would let the user choose whether to use psycopg2 or psycopg2-binary.
django-redshift-backend relies on psycopg2, so either one is required. However, if they were unaware of the option, they could create an environment where psycopg2 was not installed.
So I changed the method to change psycopg2 to a direct dependency, and if you want to select psycopg2-binary additionally, install it with
pip install django-redshift-backend[psycopg2-binary].