-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add psycopg support (v3) and remove explicit import of optional dep psycopg2 #149
Comments
Yes, it was not good to make psycopg2 imports mandatory. Regarding psycopg3 support, it is not currently possible to adopt it due to the fact that django-redshift-backend depends on the django 4.0 code base ( #116 (comment) ). |
I have created a pull request to fix this problem. |
Looks good to me ! Thanks for the quick response, I hope you can support psycopg 3 soon |
Is this still accurate? The 4.0.0 release added Django 4.2 support - https://github.com/jazzband/django-redshift-backend/releases/tag/4.0.0
|
Yes. django-redshift-backend contains copy of Django-4.0 code to support django-4.2. |
this commit works fine with uv-0.4.17, but not fine with pip-24.2 refs: - pypa/pip#8686 - https://discuss.python.org/t/adding-a-default-extra-require-environment/4898 - https://discuss.python.org/t/the-extra-environment-marker-and-its-operators/4976
@fontaineajulien I found that the PR #150 I had you look at before didn't work. I've made a new PR #159, so I'd be happy if you could take a look at it. Thank you. |
I will merge and proceed with the release. |
#149 Added a clear message on ImportError when the psycopg2 package cannot be found.
Subject:
psycopg2
is an optional dependency but actually imported inbase.py
Problem
psycopg2
was not explicitly imported in 3.0.0 but since 4.0.0 it is imported inbase.py
Procedure to reproduce the problem
Install the package without the optional dependency on psycopg2
Error logs / results
Expected results
It would be great to be able to use
psycopg
(v3) or at least makepsycopg2
mandatoryEnvironment info
The text was updated successfully, but these errors were encountered: