Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reformat sorting of sort function #23593

Closed
wants to merge 9 commits into from

Conversation

anudeeps0306
Copy link
Contributor

Added docstring to sort function

Close #779

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@anudeeps0306 anudeeps0306 changed the title Data type Reformat sorting of sort function Sep 14, 2023
@anudeeps0306 anudeeps0306 mentioned this pull request Sep 14, 2023
3 tasks
@a0m0rajab a0m0rajab changed the title Reformat sorting of sort function docs: Reformat sorting of sort function Sep 14, 2023
@a0m0rajab a0m0rajab changed the title docs: Reformat sorting of sort function docs:Reformat sorting of sort function Sep 14, 2023
@a0m0rajab a0m0rajab changed the title docs:Reformat sorting of sort function docs: reformat sorting of sort function Sep 14, 2023
@a0m0rajab a0m0rajab modified the milestone: #10388 Sep 14, 2023
@anudeeps0306
Copy link
Contributor Author

Hello, @theRealBird , could you please review my pull request?

@ivy-seed ivy-seed assigned Ishticode and unassigned theRealBird Sep 27, 2023
@Ishticode
Copy link
Contributor

Ishticode commented Oct 4, 2023

Hi @anudeeps0306
Thanks for the PR.
We don't add docstring to the backend functions as this PR seems to add the docstring to ivy/functional/backends/jax/sorting.py.
The docstring already exist where it should be i.e. in ivy/functional/ivy/sorting.py.
please check the first paragraph here.
Therefore I will close this PR. If you think otherwise pls feel free to reopen. Thanks 🙂️

@Ishticode Ishticode closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reformat sorting
4 participants